appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py - Issue 2026283002: [Findit] Adding logic to force try jobs regardless of bailout or previous results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py

Issue 2026283002: [Findit] Adding logic to force try jobs regardless of bailout or previous results (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Addressing comments and rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/test/analyze_build_failure_pipeline_test.py ('k') | appengine/findit/waterfall/test/run_try_job_for_reliable_failure_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py

diff --git a/appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py b/appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py

index dd7dc4361ecce25dd206ec84f25abe3c40611a2b..9efcfb40cd2ab53ae5d13c80ae6972fc28dd426a 100644

--- a/appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py

+++ b/appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py

@@ -16,7 +16,8 @@ from waterfall import build_failure_analysis_pipelines

class _MockRootPipeline(object):

STARTED = False

- def __init__(self, master_name, builder_name, build_number, build_completed):

+ def __init__(self, master_name, builder_name, build_number, build_completed,

+ force_try_job):

pass

def pipeline_status_path(self):

@@ -166,7 +167,8 @@ class BuildFailureAnalysisPipelinesTest(testing.AppengineTestCase):

build_failure_analysis_pipelines.ScheduleAnalysisIfNeeded(

master_name, builder_name, build_number, failed_steps=['a'],

- build_completed=False, force=False, queue_name=constants.DEFAULT_QUEUE)

+ build_completed=False, force=False, force_try_job=False,

+ queue_name=constants.DEFAULT_QUEUE)

analysis = WfAnalysis.Get(master_name, builder_name, build_number)