[Findit] Adding logic to force try jobs regardless of bailout or previous results

appengine/findit/handlers/test/build_failure_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import re
 
 from google.appengine.ext import testbed
 
 import webapp2
 import webtest
 
 from handlers import build_failure
 from handlers import handlers_util
 from handlers import result_status
 from model.wf_analysis import WfAnalysis
 from model.wf_try_job import WfTryJob
 from model import analysis_status
 from model.wf_analysis import WfAnalysis
 from waterfall import buildbot
 from waterfall.test import wf_testcase
 
 # Root directory appengine/findit.
 ROOT_DIR = os.path.join(os.path.dirname(__file__),
                         os.path.pardir, os.path.pardir)
 
 SAMPLE_TRY_JOB_INFO = {
     'm/b/119': {
-        'step1 on platform':{
+        'step1 on platform': {
             'try_jobs': [
                 {
                     'ref_name': 'step1',
                     'try_job_key': 'm/b/119',
                     'task_id': 'task1',
                     'task_url': 'url/task1',
                     'status': analysis_status.COMPLETED,
                     'try_job_url': (
                         'http://build.chromium.org/p/tryserver.chromium.'
                         'linux/builders/linux_variable/builds/121'),
@@ skipping 74 matching lines @@
 
   def setUp(self):
     super(BuildFailureTest, self).setUp()
 
     # Setup clean task queues.
     self.testbed.init_taskqueue_stub(root_path=ROOT_DIR)
     self.taskqueue_stub = self.testbed.get_stub(testbed.TASKQUEUE_SERVICE_NAME)
     for queue in self.taskqueue_stub.GetQueues():
       self.taskqueue_stub.FlushQueue(queue['name'])
 
-    def MockedGetAllTryJobResults(master_name, builder_name, build_number):
+    def MockedGetAllTryJobResults(master_name, builder_name, build_number, _):
       build_key = '%s/%s/%d' % (master_name, builder_name, build_number)
       return SAMPLE_TRY_JOB_INFO.get(build_key, None)
     self.mock(handlers_util, 'GetAllTryJobResults', MockedGetAllTryJobResults)
 
   def testGetTriageHistoryWhenUserIsNotAdmin(self):
     analysis = WfAnalysis.Create('m', 'b', 1)
     analysis.status = analysis_status.COMPLETED
     analysis.triage_history = [
         {
             'triage_timestamp': 1438380761,
@@ skipping 267 matching lines @@
                 ],
                 'tests': ['test2', 'test3']
             },
             {
                 'first_failure': 119,
                 'last_pass': 118,
                 'supported': True,
                 'suspected_cls': [],
                 'tests': ['test4']
             },
-           {
+            {
                 'first_failure': 120,
                 'last_pass': 119,
                 'supported': True,
                 'suspected_cls': [],
                 'tests': ['test1', 'test5']
             }
         ]
     }
 
     updated_result = build_failure._GetAnalysisResultWithTryJobInfo(
-        organized_results, master_name, builder_name, build_number)
+        False, organized_results, master_name, builder_name, build_number)
 
     expected_result = {
-        'step1 on platform':{
+        'step1 on platform': {
             'results': {
                 'reliable_failures': [
                     {
-                        'try_job':{
+                        'try_job': {
                             'ref_name': 'step1',
                             'try_job_key': 'm/b/119',
                             'task_id': 'task1',
                             'task_url': 'url/task1',
                             'status': analysis_status.COMPLETED,
                             'try_job_url': (
                                 'http://build.chromium.org/p/tryserver.chromium'
                                 '.linux/builders/linux_variable/builds/121'),
                             'try_job_build_number': 121,
                             'tests': ['test3'],
@@ skipping 14 matching lines @@
                                     },
                                 }
                             ]
                         },
                         'tests': ['test3'],
                         'first_failure': 119,
                         'last_pass': 118,
                         'supported': True
                     },
                     {
-                        'try_job':{
+                        'try_job': {
                             'ref_name': 'step1',
                             'try_job_key': 'm/b/119',
                             'task_id': 'task1',
                             'task_url': 'url/task1',
                             'status': analysis_status.COMPLETED,
                             'try_job_url': (
                                 'http://build.chromium.org/p/tryserver.chromium'
                                 '.linux/builders/linux_variable/builds/121'),
                             'try_job_build_number': 121,
                             'culprit': {
@@ skipping 20 matching lines @@
                             ]
                         },
                         'tests': ['test2'],
                         'first_failure': 119,
                         'last_pass': 118,
                         'supported': True
                     }
                 ],
                 'flaky_failures': [
                     {
-                        'try_job':{
+                        'try_job': {
                             'ref_name': 'step1',
                             'try_job_key': 'm/b/119',
                             'status': result_status.FLAKY,
                             'task_id': 'task1',
                             'task_url': 'url/task1',
                             'tests': ['test4']
                         },
                         'heuristic_analysis': {
                             'suspected_cls': []
                         },
                         'tests': ['test4'],
                         'first_failure': 119,
                         'last_pass': 118,
                         'supported': True
                     }
                 ],
                 'unclassified_failures': [
                     {
-                        'try_job':{
+                        'try_job': {
                             'ref_name': 'step1',
                             'try_job_key': 'm/b/120',
                             'status': result_status.UNKNOWN,
                             'task_id': 'task2',
                             'task_url': 'url/task2',
                             'tests': ['test5']
                         },
                         'heuristic_analysis': {
                             'suspected_cls': []
                         },
                         'tests': ['test5'],
                         'first_failure': 120,
                         'last_pass': 119,
                         'supported': True
                     },
                     {
-                        'try_job':{
+                        'try_job': {
                             'ref_name': 'step1',
                             'try_job_key': 'm/b/120',
                             'status': result_status.NO_TRY_JOB_REASON_MAP[
                                 analysis_status.PENDING],
                             'task_id': 'task2',
                             'task_url': 'url/task2',
                             'tests': ['test1']
                         },
                         'heuristic_analysis': {
                             'suspected_cls': []
                         },
                         'tests': ['test1'],
                         'first_failure': 120,
                         'last_pass': 119,
                         'supported': True
                     }
                 ]
             }
         }
     }
 
     self.assertEqual(expected_result, updated_result)
 
   def testGetAnalysisResultWithTryJobInfoNoTryJobInfo(self):
     organized_results = {
-        'step1 on platform':{}
+        'step1 on platform': {}
     }
     result = build_failure._GetAnalysisResultWithTryJobInfo(
-        organized_results, 'n', 'b', 120)
+        False, organized_results, 'n', 'b', 120)
     self.assertEqual({}, result)
 
   def testGetAnalysisResultWithTryJobInfoCompile(self):
     organized_results = {
         'compile': [
             {
                 'first_failure': 120,
                 'last_pass': 119,
                 'supported': True,
                 'suspected_cls': [
                     {
                         'build_number': 120,
                         'repo_name': 'chromium',
                         'revision': 'rev2',
                         'commit_position': None,
                         'url': None,
                         'score': 2,
                         'hints': {
                             'modified f99_2.cc (and it was in log)': 2,
                         },
                     }
                 ],
                 'tests': []
             }
         ]
     }
     result = build_failure._GetAnalysisResultWithTryJobInfo(
-        organized_results, 'm', 'b', 120)
+        False, organized_results, 'm', 'b', 120)
 
     expected_result = {
-        'compile':{
+        'compile': {
             'results': {
                 'reliable_failures': [
                     {
                         'try_job': {
                             'try_job_key': 'm/b/120',
                             'status': analysis_status.COMPLETED,
                             'try_job_build_number': 120,
                             'try_job_url': (
                                 'http://build.chromium.org/p/tryserver.chromium'
                                 '.linux/builders/linux_variable/builds/120'),
                             'culprit': {
                                 'revision': 'rev2',
                                 'commit_position': '2',
                                 'review_url': 'url_2'
                             }
                         },
                         'heuristic_analysis': {
                             'suspected_cls': [
                                 {
                                     'build_number': 120,
                                     'repo_name': 'chromium',
                                     'revision': 'rev2',
                                     'commit_position': None,
                                     'url': None,
                                     'score': 2,
-                                    'hints': {('modified f99_2.cc '
-                                              '(and it was in log)'): 2
+                                    'hints': {
+                                        ('modified f99_2.cc '
+                                         '(and it was in log)'): 2
                                     },
                                 }
                             ]
                         },
                         'tests': [],
                         'first_failure': 120,
                         'last_pass': 119,
                         'supported': True
                     }
                 ]
@@ skipping 121 matching lines @@
         },
         'failed': False,
     }
 
     build_url = buildbot.CreateBuildUrl('m', 'b', 123)
     response = self.test_app.get('/build-failure',
                                  params={'url': build_url, 'format': 'json'})
 
     self.assertEquals(200, response.status_int)
     self.assertEqual(expected_try_job_result, response.json_body['try_job'])