Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2026253002: Revert of headless: Allow protocol handler customization (Closed)

Created:
4 years, 6 months ago by Sami
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of headless: Allow protocol handler customization (patchset #3 id:40001 of https://codereview.chromium.org/2024973002/ ) Reason for revert: Doing another review round with net/. Original issue's description: > headless: Allow protocol handler customization > > Allow headless clients to provide custom protocol handlers. This lets > the clients override how URL requests are fulfilled for different > schemes types. > > Design doc: https://docs.google.com/document/d/1m4CCZGJWOJdHY5MVwQqY3sT-5kBoz7NqmGvIb6-l3fM/edit#bookmark=id.5bqp8w95liri > > BUG=595353 > > Committed: https://crrev.com/789f9abbbc69e5d485984a9d7b4e3d167054919f > Cr-Commit-Position: refs/heads/master@{#396884} TBR=altimin@chromium.org,alexclarke@chromium.org,eseckler@chromium.org,rsleevi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595353 Committed: https://crrev.com/1b67e83a4e32a1acbb89e4680d4ec2771ab765ad Cr-Commit-Position: refs/heads/master@{#397093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -217 lines) Patch
M headless/lib/browser/headless_url_request_context_getter.cc View 2 chunks +10 lines, -21 lines 0 comments Download
M headless/lib/headless_browser_browsertest.cc View 2 chunks +0 lines, -126 lines 0 comments Download
M headless/public/headless_browser.h View 5 chunks +0 lines, -11 lines 0 comments Download
M headless/public/headless_browser.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M headless/test/headless_browser_test.h View 2 chunks +0 lines, -8 lines 0 comments Download
M headless/test/headless_browser_test.cc View 3 chunks +0 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sami
Created Revert of headless: Allow protocol handler customization
4 years, 6 months ago (2016-06-01 09:36:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026253002/1
4 years, 6 months ago (2016-06-01 09:36:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 09:37:24 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 09:38:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b67e83a4e32a1acbb89e4680d4ec2771ab765ad
Cr-Commit-Position: refs/heads/master@{#397093}

Powered by Google App Engine
This is Rietveld 408576698