Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: net/url_request/certificate_report_sender.cc

Issue 2026213002: Refactor CertificateReportSender (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/certificate_report_sender.h ('k') | net/url_request/certificate_report_sender_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/certificate_report_sender.cc
diff --git a/net/url_request/certificate_report_sender.cc b/net/url_request/certificate_report_sender.cc
deleted file mode 100644
index 672e29194ab0f2cba0537bbf25698d73c5b7798c..0000000000000000000000000000000000000000
--- a/net/url_request/certificate_report_sender.cc
+++ /dev/null
@@ -1,86 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "net/url_request/certificate_report_sender.h"
-
-#include <utility>
-
-#include "base/stl_util.h"
-#include "net/base/elements_upload_data_stream.h"
-#include "net/base/load_flags.h"
-#include "net/base/request_priority.h"
-#include "net/base/upload_bytes_element_reader.h"
-#include "net/url_request/url_request_context.h"
-#include "net/url_request/url_request_status.h"
-
-namespace net {
-
-CertificateReportSender::CertificateReportSender(
- URLRequestContext* request_context,
- CookiesPreference cookies_preference)
- : CertificateReportSender(request_context,
- cookies_preference,
- ErrorCallback()) {}
-
-CertificateReportSender::CertificateReportSender(
- URLRequestContext* request_context,
- CookiesPreference cookies_preference,
- const ErrorCallback& error_callback)
- : request_context_(request_context),
- cookies_preference_(cookies_preference),
- error_callback_(error_callback) {}
-
-CertificateReportSender::~CertificateReportSender() {
- // Cancel all of the uncompleted requests.
- STLDeleteElements(&inflight_requests_);
-}
-
-void CertificateReportSender::Send(const GURL& report_uri,
- const std::string& report) {
- std::unique_ptr<URLRequest> url_request =
- request_context_->CreateRequest(report_uri, DEFAULT_PRIORITY, this);
-
- int load_flags =
- LOAD_BYPASS_CACHE | LOAD_DISABLE_CACHE | LOAD_DO_NOT_SEND_AUTH_DATA;
- if (cookies_preference_ != SEND_COOKIES) {
- load_flags |= LOAD_DO_NOT_SEND_COOKIES | LOAD_DO_NOT_SAVE_COOKIES;
- }
- url_request->SetLoadFlags(load_flags);
-
- url_request->set_method("POST");
-
- std::unique_ptr<UploadElementReader> reader(
- UploadOwnedBytesElementReader::CreateWithString(report));
- url_request->set_upload(
- ElementsUploadDataStream::CreateWithReader(std::move(reader), 0));
-
- URLRequest* raw_url_request = url_request.get();
- inflight_requests_.insert(url_request.release());
- raw_url_request->Start();
-}
-
-void CertificateReportSender::SetErrorCallback(
- const ErrorCallback& error_callback) {
- error_callback_ = error_callback;
-}
-
-void CertificateReportSender::OnResponseStarted(URLRequest* request) {
- if (!request->status().is_success()) {
- DVLOG(1) << "Failed to send certificate report for "
- << request->url().host();
- if (!error_callback_.is_null())
- error_callback_.Run(request->url(), request->status().error());
- }
-
- CHECK_GT(inflight_requests_.erase(request), 0u);
- // Clean up the request, which cancels it.
- delete request;
-}
-
-void CertificateReportSender::OnReadCompleted(URLRequest* request,
- int bytes_read) {
- NOTREACHED();
-}
-
-} // namespace net
« no previous file with comments | « net/url_request/certificate_report_sender.h ('k') | net/url_request/certificate_report_sender_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698