Refactor CertificateReportSender

net/url_request/report_sender_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "net/url_request/certificate_report_sender.h"
+#include "net/url_request/report_sender.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "net/base/load_flags.h"
 #include "net/base/network_delegate_impl.h"
 #include "net/base/upload_bytes_element_reader.h"
 #include "net/base/upload_data_stream.h"
@@ skipping 31 matching lines @@
   EXPECT_EQ(1u, expect_reports->erase(upload_data));
 }
 
 // Provides an error callback for report sending that sets |called| to
 // true.
 void ErrorCallback(bool* called, const GURL& report_uri, int net_error) {
   EXPECT_NE(OK, net_error);
   *called = true;
 }
 
-// A network delegate that lets tests check that a certificate report
+// A network delegate that lets tests check that a report
 // was sent. It counts the number of requests and lets tests register a
 // callback to run when the request is destroyed. It also checks that
 // the uploaded data is as expected.
-class TestCertificateReportSenderNetworkDelegate : public NetworkDelegateImpl {
+class TestReportSenderNetworkDelegate : public NetworkDelegateImpl {
  public:
-  TestCertificateReportSenderNetworkDelegate()
+  TestReportSenderNetworkDelegate()
       : url_request_destroyed_callback_(base::Bind(&base::DoNothing)),
         all_url_requests_destroyed_callback_(base::Bind(&base::DoNothing)),
         num_requests_(0),
         expect_cookies_(false) {}
 
   void ExpectReport(const std::string& report) {
     expect_reports_.insert(report);
   }
 
   void set_all_url_requests_destroyed_callback(const base::Closure& callback) {
@@ skipping 43 matching lines @@
   }
 
  private:
   base::Closure url_request_destroyed_callback_;
   base::Closure all_url_requests_destroyed_callback_;
   size_t num_requests_;
   GURL expect_url_;
   std::set<std::string> expect_reports_;
   bool expect_cookies_;
 
-  DISALLOW_COPY_AND_ASSIGN(TestCertificateReportSenderNetworkDelegate);
+  DISALLOW_COPY_AND_ASSIGN(TestReportSenderNetworkDelegate);
 };
 
-class CertificateReportSenderTest : public ::testing::Test {
+class ReportSenderTest : public ::testing::Test {
  public:
-  CertificateReportSenderTest() : context_(true) {
+  ReportSenderTest() : context_(true) {
     context_.set_network_delegate(&network_delegate_);
     context_.Init();
   }
 
   void SetUp() override {
     URLRequestFailedJob::AddUrlHandler();
     URLRequestMockDataJob::AddUrlHandler();
   }
 
   void TearDown() override { URLRequestFilter::GetInstance()->ClearHandlers(); }
 
   TestURLRequestContext* context() { return &context_; }
 
  protected:
-  void SendReport(CertificateReportSender* reporter,
+  void SendReport(ReportSender* reporter,
                   const std::string& report,
                   const GURL& url,
                   size_t request_sequence_number) {
     base::RunLoop run_loop;
     network_delegate_.set_url_request_destroyed_callback(
         run_loop.QuitClosure());
 
     network_delegate_.set_expect_url(url);
     network_delegate_.ExpectReport(report);
 
     EXPECT_EQ(request_sequence_number, network_delegate_.num_requests());
 
     reporter->Send(url, report);
 
     // The report is sent asynchronously, so wait for the report's
     // URLRequest to be destroyed before checking that the report was
     // sent.
     run_loop.Run();
 
     EXPECT_EQ(request_sequence_number + 1, network_delegate_.num_requests());
   }
 
-  TestCertificateReportSenderNetworkDelegate network_delegate_;
+  TestReportSenderNetworkDelegate network_delegate_;
 
  private:
   TestURLRequestContext context_;
 };
 
-// Test that CertificateReportSender::Send creates a URLRequest for the
+// Test that ReportSender::Send creates a URLRequest for the
 // endpoint and sends the expected data.
-TEST_F(CertificateReportSenderTest, SendsRequest) {
+TEST_F(ReportSenderTest, SendsRequest) {
   GURL url = URLRequestMockDataJob::GetMockHttpsUrl("dummy data", 1);
-  CertificateReportSender reporter(
-      context(), CertificateReportSender::DO_NOT_SEND_COOKIES);
+  ReportSender reporter(context(), ReportSender::DO_NOT_SEND_COOKIES);
   SendReport(&reporter, kDummyReport, url, 0);
 }
 
-TEST_F(CertificateReportSenderTest, SendMultipleReportsSequentially) {
+TEST_F(ReportSenderTest, SendMultipleReportsSequentially) {
   GURL url = URLRequestMockDataJob::GetMockHttpsUrl("dummy data", 1);
-  CertificateReportSender reporter(
-      context(), CertificateReportSender::DO_NOT_SEND_COOKIES);
+  ReportSender reporter(context(), ReportSender::DO_NOT_SEND_COOKIES);
   SendReport(&reporter, kDummyReport, url, 0);
   SendReport(&reporter, kDummyReport, url, 1);
 }
 
-TEST_F(CertificateReportSenderTest, SendMultipleReportsSimultaneously) {
+TEST_F(ReportSenderTest, SendMultipleReportsSimultaneously) {
   base::RunLoop run_loop;
   network_delegate_.set_all_url_requests_destroyed_callback(
       run_loop.QuitClosure());
 
   GURL url = URLRequestMockDataJob::GetMockHttpsUrl("dummy data", 1);
   network_delegate_.set_expect_url(url);
   network_delegate_.ExpectReport(kDummyReport);
   network_delegate_.ExpectReport(kSecondDummyReport);
 
-  CertificateReportSender reporter(
-      context(), CertificateReportSender::DO_NOT_SEND_COOKIES);
+  ReportSender reporter(context(), ReportSender::DO_NOT_SEND_COOKIES);
 
   EXPECT_EQ(0u, network_delegate_.num_requests());
 
   reporter.Send(url, kDummyReport);
   reporter.Send(url, kSecondDummyReport);
 
   run_loop.Run();
 
   EXPECT_EQ(2u, network_delegate_.num_requests());
 }
 
 // Test that pending URLRequests get cleaned up when the report sender
 // is deleted.
-TEST_F(CertificateReportSenderTest, PendingRequestGetsDeleted) {
+TEST_F(ReportSenderTest, PendingRequestGetsDeleted) {
   bool url_request_destroyed = false;
   network_delegate_.set_url_request_destroyed_callback(base::Bind(
       &MarkURLRequestDestroyed, base::Unretained(&url_request_destroyed)));
 
   GURL url = URLRequestFailedJob::GetMockHttpUrlWithFailurePhase(
       URLRequestFailedJob::START, ERR_IO_PENDING);
   network_delegate_.set_expect_url(url);
   network_delegate_.ExpectReport(kDummyReport);
 
   EXPECT_EQ(0u, network_delegate_.num_requests());
 
-  std::unique_ptr<CertificateReportSender> reporter(new CertificateReportSender(
-      context(), CertificateReportSender::DO_NOT_SEND_COOKIES));
+  std::unique_ptr<ReportSender> reporter(
+      new ReportSender(context(), ReportSender::DO_NOT_SEND_COOKIES));
   reporter->Send(url, kDummyReport);
   reporter.reset();
 
   EXPECT_EQ(1u, network_delegate_.num_requests());
   EXPECT_TRUE(url_request_destroyed);
 }
 
 // Test that a request that returns an error gets cleaned up.
-TEST_F(CertificateReportSenderTest, ErroredRequestGetsDeleted) {
+TEST_F(ReportSenderTest, ErroredRequestGetsDeleted) {
   GURL url = URLRequestFailedJob::GetMockHttpsUrl(ERR_FAILED);
-  CertificateReportSender reporter(
-      context(), CertificateReportSender::DO_NOT_SEND_COOKIES);
+  ReportSender reporter(context(), ReportSender::DO_NOT_SEND_COOKIES);
   // SendReport will block until the URLRequest is destroyed.
   SendReport(&reporter, kDummyReport, url, 0);
 }
 
 // Test that the error callback, if provided, gets called when a request
 // returns an error.
-TEST_F(CertificateReportSenderTest, ErroredRequestCallsCallback) {
+TEST_F(ReportSenderTest, ErroredRequestCallsCallback) {
   bool error_callback_called = false;
   GURL url = URLRequestFailedJob::GetMockHttpsUrl(ERR_FAILED);
-  CertificateReportSender reporter(
-      context(), CertificateReportSender::DO_NOT_SEND_COOKIES,
-      base::Bind(ErrorCallback, &error_callback_called));
+  ReportSender reporter(context(), ReportSender::DO_NOT_SEND_COOKIES,
+                        base::Bind(ErrorCallback, &error_callback_called));
   // SendReport will block until the URLRequest is destroyed.
   SendReport(&reporter, kDummyReport, url, 0);
   EXPECT_TRUE(error_callback_called);
 }
 
 // Test that the error callback does not get called when a request
 // does not return an error.
-TEST_F(CertificateReportSenderTest, SuccessfulRequestDoesNotCallErrorCallback) {
+TEST_F(ReportSenderTest, SuccessfulRequestDoesNotCallErrorCallback) {
   bool error_callback_called = false;
   GURL url = URLRequestMockDataJob::GetMockHttpsUrl("dummy data", 1);
-  CertificateReportSender reporter(
-      context(), CertificateReportSender::DO_NOT_SEND_COOKIES,
-      base::Bind(ErrorCallback, &error_callback_called));
+  ReportSender reporter(context(), ReportSender::DO_NOT_SEND_COOKIES,
+                        base::Bind(ErrorCallback, &error_callback_called));
   SendReport(&reporter, kDummyReport, url, 0);
   EXPECT_FALSE(error_callback_called);
 }
 
 // Test that cookies are sent or not sent according to the error
 // reporter's cookies preference.
 
-TEST_F(CertificateReportSenderTest, SendCookiesPreference) {
+TEST_F(ReportSenderTest, SendCookiesPreference) {
   GURL url = URLRequestMockDataJob::GetMockHttpsUrl("dummy data", 1);
-  CertificateReportSender reporter(context(),
-                                   CertificateReportSender::SEND_COOKIES);
+  ReportSender reporter(context(), ReportSender::SEND_COOKIES);
 
   network_delegate_.set_expect_cookies(true);
   SendReport(&reporter, kDummyReport, url, 0);
 }
 
-TEST_F(CertificateReportSenderTest, DoNotSendCookiesPreference) {
+TEST_F(ReportSenderTest, DoNotSendCookiesPreference) {
   GURL url = URLRequestMockDataJob::GetMockHttpsUrl("dummy data", 1);
-  CertificateReportSender reporter(
-      context(), CertificateReportSender::DO_NOT_SEND_COOKIES);
+  ReportSender reporter(context(), ReportSender::DO_NOT_SEND_COOKIES);
 
   network_delegate_.set_expect_cookies(false);
   SendReport(&reporter, kDummyReport, url, 0);
 }
 
 }  // namespace
 }  // namespace net