Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: src/x64/debug-x64.cc

Issue 20262004: Use kRegisterSize when calling C++ runtime (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 __ pop(kScratchRegister); 169 __ pop(kScratchRegister);
170 __ SmiToInteger32(kScratchRegister, kScratchRegister); 170 __ SmiToInteger32(kScratchRegister, kScratchRegister);
171 __ lea(rsp, Operand(rsp, kScratchRegister, times_pointer_size, 0)); 171 __ lea(rsp, Operand(rsp, kScratchRegister, times_pointer_size, 0));
172 172
173 // Get rid of the internal frame. 173 // Get rid of the internal frame.
174 } 174 }
175 175
176 // If this call did not replace a call but patched other code then there will 176 // If this call did not replace a call but patched other code then there will
177 // be an unwanted return address left on the stack. Here we get rid of that. 177 // be an unwanted return address left on the stack. Here we get rid of that.
178 if (convert_call_to_jmp) { 178 if (convert_call_to_jmp) {
179 __ addq(rsp, Immediate(kPointerSize)); 179 __ addq(rsp, Immediate(kPCOnStackSize));
180 } 180 }
181 181
182 // Now that the break point has been handled, resume normal execution by 182 // Now that the break point has been handled, resume normal execution by
183 // jumping to the target address intended by the caller and that was 183 // jumping to the target address intended by the caller and that was
184 // overwritten by the address of DebugBreakXXX. 184 // overwritten by the address of DebugBreakXXX.
185 ExternalReference after_break_target = 185 ExternalReference after_break_target =
186 ExternalReference(Debug_Address::AfterBreakTarget(), masm->isolate()); 186 ExternalReference(Debug_Address::AfterBreakTarget(), masm->isolate());
187 __ movq(kScratchRegister, after_break_target); 187 __ movq(kScratchRegister, after_break_target);
188 __ jmp(Operand(kScratchRegister, 0)); 188 __ jmp(Operand(kScratchRegister, 0));
189 } 189 }
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 354
355 const bool Debug::kFrameDropperSupported = true; 355 const bool Debug::kFrameDropperSupported = true;
356 356
357 #undef __ 357 #undef __
358 358
359 #endif // ENABLE_DEBUGGER_SUPPORT 359 #endif // ENABLE_DEBUGGER_SUPPORT
360 360
361 } } // namespace v8::internal 361 } } // namespace v8::internal
362 362
363 #endif // V8_TARGET_ARCH_X64 363 #endif // V8_TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698