Use kRegisterSize when calling C++ runtime

Use kRegisterSize when calling C++ runtime

[haitao.feng, 2013-07-25 11:40:49]

Weiliang is helping me for upstreaming X32 port. This CL will eliminate all the
__q annotation from https://codereview.chromium.org/18014003/. I have added some
explanation in the codes for your review.

LGTM with a nit. Could we change the title to "Use
kRegisterSize/kPCOnStackSize/kFPOnStackSize to make the semantics accurate for
X64" or a better sentence?

I could help commit this CL after it gets lgtm from reviewers.

https://codereview.chromium.org/20262004/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/20262004/diff/1/src/x64/code-stubs-x64.cc#new...
src/x64/code-stubs-x64.cc:2767: __ movq(Operand(rsp, (argument_slots_on_stack -
1) * kRegisterSize),
X64 and X32 both use register and 8-byte stack slots in their calling
conversion. kRegisterSize makes those codes apply for both.

https://codereview.chromium.org/20262004/diff/1/src/x64/deoptimizer-x64.cc
File src/x64/deoptimizer-x64.cc (right):

https://codereview.chromium.org/20262004/diff/1/src/x64/deoptimizer-x64.cc#ne...
src/x64/deoptimizer-x64.cc:410: const int kSavedRegistersAreaSize =
kNumberOfRegisters * kRegisterSize +
For X32, we used 8-byte push for bailout id and register saving. Using kRegister
here make those code apply for both.

https://codereview.chromium.org/20262004/diff/1/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):

https://codereview.chromium.org/20262004/diff/1/src/x64/macro-assembler-x64.c...
src/x64/macro-assembler-x64.cc:3510: arg_stack_space * kRegisterSize;
Explained in the code-stubs-x64.cc for calling conversion.

[danno, 2013-07-25 20:10:45]

I think you should wait for the final design of
https://codereview.chromium.org/19857006/ and make sure to use that mechanism.

[weiliang.lin2, 2013-07-26 08:59:30]

On 2013/07/25 20:10:45, danno wrote:
> I think you should wait for the final design of
> https://codereview.chromium.org/19857006/ and make sure to use that mechanism.

Refine the patch to use kRegisterSize for calling convention stuff.