tools/android/loading: Lets some execption pass through chrome controller's Open

tools/android/loading: Lets some execption pass through chrome controller's Open

BUG=582080
Committed: https://crrev.com/79b66d38a29dda10dc6801a5e9d5950d09abb39a
Cr-Commit-Position: refs/heads/master@{#397109}

[gabadie, 2016-06-01 11:17:01]

gabadie@chromium.org changed reviewers:
+ droger@chromium.org

[droger, 2016-06-01 11:23:01]

lgtm

[gabadie, 2016-06-01 11:26:02]

The CQ bit was checked by gabadie@chromium.org

[commit-bot: I haz the power, 2016-06-01 11:26:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026193003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026193003/1

[commit-bot: I haz the power, 2016-06-01 12:12:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-01 12:13:41]

Description was changed from

==========
tools/android/loading: Lets some execption pass through chrome controller's Open

BUG=582080
==========

to

==========
tools/android/loading: Lets some execption pass through chrome controller's Open

BUG=582080

Committed: https://crrev.com/79b66d38a29dda10dc6801a5e9d5950d09abb39a
Cr-Commit-Position: refs/heads/master@{#397109}
==========

[commit-bot: I haz the power, 2016-06-01 12:13:42]

Patchset 1 (id:??) landed as
https://crrev.com/79b66d38a29dda10dc6801a5e9d5950d09abb39a
Cr-Commit-Position: refs/heads/master@{#397109}

[pasko, 2016-06-01 12:47:16]

pasko@chromium.org changed reviewers:
+ pasko@chromium.org

[pasko, 2016-06-01 12:47:17]

fly-by ;o)

https://codereview.chromium.org/2026193003/diff/1/tools/android/loading/contr...
File tools/android/loading/controller.py (right):

https://codereview.chromium.org/2026193003/diff/1/tools/android/loading/contr...
tools/android/loading/controller.py:85: _PASSTHROUGH_WHITE_LIST = (MemoryError,
SyntaxError)
wow, interesting, did you actually hit a memory error?
are there other unrecoverable errors we want to stop on?

[gabadie, 2016-06-01 12:54:43]

https://codereview.chromium.org/2026193003/diff/1/tools/android/loading/contr...
File tools/android/loading/controller.py (right):

https://codereview.chromium.org/2026193003/diff/1/tools/android/loading/contr...
tools/android/loading/controller.py:85: _PASSTHROUGH_WHITE_LIST = (MemoryError,
SyntaxError)
On 2016/06/01 12:47:17, pasko wrote:
> wow, interesting, did you actually hit a memory error?
> are there other unrecoverable errors we want to stop on?

It is not obvious in this CL but there is exceptions such as SystemExit or
KeyboardInterupt are not in subclasses of Exception but ExceptionBase. But the
except: implictly does a except ExceptionBase, the reason why we change below
from except: to except Exception:.

The issue is that there is some exception such as the one listed here that are
still subclasses of Exception, the reason we are doing this
_PASSTHROUGH_WHITE_LIST.

[pasko, 2016-06-01 13:42:22]

https://codereview.chromium.org/2026193003/diff/1/tools/android/loading/contr...
File tools/android/loading/controller.py (right):

https://codereview.chromium.org/2026193003/diff/1/tools/android/loading/contr...
tools/android/loading/controller.py:85: _PASSTHROUGH_WHITE_LIST = (MemoryError,
SyntaxError)
On 2016/06/01 12:54:43, gabadie wrote:
> On 2016/06/01 12:47:17, pasko wrote:
> > wow, interesting, did you actually hit a memory error?
> > are there other unrecoverable errors we want to stop on?
> 
> It is not obvious in this CL but there is exceptions such as SystemExit or
> KeyboardInterupt are not in subclasses of Exception but ExceptionBase. But the
> except: implictly does a except ExceptionBase, the reason why we change below
> from except: to except Exception:.
> 
> The issue is that there is some exception such as the one listed here that are
> still subclasses of Exception, the reason we are doing this
> _PASSTHROUGH_WHITE_LIST.

thanks, it is indeed not obvious