Disable IframeNavigateToInaccessible test on Site Isolation FYI bots.

Disable IframeNavigateToInaccessible test on Site Isolation FYI bots.

BUG=576867
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/a4a128d5c500528e70139c14c51bb326fe357746
Cr-Commit-Position: refs/heads/master@{#397068}

[nasko, 2016-05-31 23:25:55]

nasko@chromium.org changed reviewers:
+ lukasza@chromium.org

[nasko, 2016-05-31 23:25:56]

Hey Lukasz,
Can you review this CL for me?
Thanks in advance!
Nasko

[Łukasz Anforowicz, 2016-05-31 23:32:56]

lgtm with nits

For a moment I wanted to suggest asking CQ to try linux_site_isolation bot, but
then I realized that we only run --isolate-extensions mode on the Windows FYI
bot (so there is no trybot running --isolate-extensions mode).

https://codereview.chromium.org/2026163002/diff/1/testing/buildbot/filters/is...
File testing/buildbot/filters/isolate-extensions.browser_tests.filter (right):

https://codereview.chromium.org/2026163002/diff/1/testing/buildbot/filters/is...
testing/buildbot/filters/isolate-extensions.browser_tests.filter:6: #
crbug.com/576867:
ExtensionResourceRequestPolicyTest.IframeNavigateToInaccessible fails in
--isolate-extensions mode.
nit: Can you please refer to this bug in the CL description?

https://codereview.chromium.org/2026163002/diff/1/testing/buildbot/filters/is...
testing/buildbot/filters/isolate-extensions.browser_tests.filter:6: #
crbug.com/576867:
ExtensionResourceRequestPolicyTest.IframeNavigateToInaccessible fails in
--isolate-extensions mode.
Question: does this test only fail in --isolate-extensions mode?  If it also
fails in --site-per-process mode, then we might need to tweak one other filter
file: site-per-process.browser_tests.filter.

https://codereview.chromium.org/2026163002/diff/1/testing/buildbot/filters/is...
testing/buildbot/filters/isolate-extensions.browser_tests.filter:7:
-ExtensionResourceRequestPolicyTest.IframeNavigateToInaccessible
I assume this is a new test (and that this explains why I haven't been able to
find this test on code search, when I tried to check if the test name matches).

[nasko, 2016-05-31 23:45:51]

Description was changed from

==========
Disable IframeNavigateToInaccessible test on Site Isolation FYI bots.

BUG=
==========

to

==========
Disable IframeNavigateToInaccessible test on Site Isolation FYI bots.

BUG=576867
==========

[nasko, 2016-05-31 23:46:43]

Description was changed from

==========
Disable IframeNavigateToInaccessible test on Site Isolation FYI bots.

BUG=576867
==========

to

==========
Disable IframeNavigateToInaccessible test on Site Isolation FYI bots.

BUG=576867
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[nasko, 2016-05-31 23:47:07]

Fixes.

https://codereview.chromium.org/2026163002/diff/1/testing/buildbot/filters/is...
File testing/buildbot/filters/isolate-extensions.browser_tests.filter (right):

https://codereview.chromium.org/2026163002/diff/1/testing/buildbot/filters/is...
testing/buildbot/filters/isolate-extensions.browser_tests.filter:6: #
crbug.com/576867:
ExtensionResourceRequestPolicyTest.IframeNavigateToInaccessible fails in
--isolate-extensions mode.
On 2016/05/31 23:32:56, Łukasz Anforowicz wrote:
> Question: does this test only fail in --isolate-extensions mode?  If it also
> fails in --site-per-process mode, then we might need to tweak one other filter
> file: site-per-process.browser_tests.filter.

Indeed it fails there too. Added an exception to that filter too.

https://codereview.chromium.org/2026163002/diff/1/testing/buildbot/filters/is...
testing/buildbot/filters/isolate-extensions.browser_tests.filter:7:
-ExtensionResourceRequestPolicyTest.IframeNavigateToInaccessible
On 2016/05/31 23:32:56, Łukasz Anforowicz wrote:
> I assume this is a new test (and that this explains why I haven't been able to
> find this test on code search, when I tried to check if the test name
matches).

It is a new test introduced by https://codereview.chromium.org/2007133004/.

[nasko, 2016-05-31 23:47:14]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 23:47:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026163002/20001

[commit-bot: I haz the power, 2016-06-01 01:27:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 01:27:36]

Dry run: This issue passed the CQ dry run.

[nasko, 2016-06-01 05:34:48]

The CQ bit was checked by nasko@chromium.org

[nasko, 2016-06-01 05:34:49]

The patchset sent to the CQ was uploaded after l-g-t-m from lukasza@chromium.org
Link to the patchset: https://codereview.chromium.org/2026163002/#ps20001
(title: "Add test exception to site-per-process filter too.")

[commit-bot: I haz the power, 2016-06-01 05:35:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026163002/20001

[commit-bot: I haz the power, 2016-06-01 05:39:04]

Description was changed from

==========
Disable IframeNavigateToInaccessible test on Site Isolation FYI bots.

BUG=576867
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Disable IframeNavigateToInaccessible test on Site Isolation FYI bots.

BUG=576867
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-06-01 05:39:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-01 05:41:23]

Description was changed from

==========
Disable IframeNavigateToInaccessible test on Site Isolation FYI bots.

BUG=576867
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Disable IframeNavigateToInaccessible test on Site Isolation FYI bots.

BUG=576867
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/a4a128d5c500528e70139c14c51bb326fe357746
Cr-Commit-Position: refs/heads/master@{#397068}
==========

[commit-bot: I haz the power, 2016-06-01 05:41:24]

Patchset 2 (id:??) landed as
https://crrev.com/a4a128d5c500528e70139c14c51bb326fe357746
Cr-Commit-Position: refs/heads/master@{#397068}