Throw TypeError instead of CastError for type coercions.

test/browser/language_tests.js

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 (function() {
   'use strict';
 
   let dart_sdk = dart_library.import('dart_sdk');
   dart_sdk._isolate_helper.startRootIsolate(function() {}, []);
   let async_helper = dart_library.import('async_helper').async_helper;
@@ skipping 15 matching lines @@
   const skip_timeout = ['skip', 'timeout'];
 
   // The number of expected unittest errors should be zero but unfortunately
   // there are a lot of broken html unittests.
   let num_expected_unittest_fails = 3;
   let num_expected_unittest_errors = 2;
 
   // TODO(jmesserly): separate StrongModeError from other errors.
   let all_status = {
     'language': {
-      'arithmetic2_test': fail,
       'assert_with_type_test_or_cast_test': skip_fail,
       'assertion_test': skip_fail,
       'async_await_test_none_multi': 'unittest',
       'async_star_await_pauses_test': skip_fail,
 
       // TODO(jmesserly): figure out why this test is hanging.
       'async_star_cancel_and_throw_in_finally_test': skip_timeout,
 
       'async_star_cancel_while_paused_test': skip_fail,
       'async_star_regression_fisk_test': skip_fail,
@@ skipping 83 matching lines @@
       'deferred_optimized_test': skip_fail,
       'deferred_redirecting_factory_test': skip_fail,
       'deferred_regression_22995_test': skip_fail,
       'deferred_shadow_load_library_test': skip_fail,
       'deferred_shared_and_unshared_classes_test': skip_fail,
       'deferred_static_seperate_test': skip_fail,
       'double_int_to_string_test': skip_fail,
       'double_to_string_test': skip_fail,
       'dynamic_test': skip_fail,
       'enum_mirror_test': skip_fail,
-      'exception_test': skip_fail,
+      'exception_test': fail,
       'execute_finally6_test': skip_fail,
       'expect_test': skip_fail,
       'extends_test_lib': skip_fail,
       'external_test_10_multi': skip_fail,
       'external_test_13_multi': skip_fail,
       'external_test_20_multi': skip_fail,
       'f_bounded_quantification3_test': skip_fail,
       'factory_type_parameter_test': skip_fail,
       'fast_method_extraction_test': skip_fail,
       'field_increment_bailout_test': skip_fail,
       'field_optimization3_test': skip_fail,
-      'field_test': skip_fail,
       'final_syntax_test_08_multi': skip_fail,
-      'first_class_types_literals_test_01_multi': skip_fail,
-      'first_class_types_literals_test_02_multi': skip_fail,
-      'first_class_types_literals_test_none_multi': skip_fail,
       'first_class_types_test': skip_fail,
       'for_in2_test': skip_fail,
       'for_variable_capture_test': skip_fail,
-      'function_propagation_test': skip_fail,
       'function_subtype0_test': skip_fail,
       'function_subtype1_test': skip_fail,
       'function_subtype2_test': skip_fail,
       'function_subtype3_test': skip_fail,
       'function_subtype_bound_closure0_test': skip_fail,
       'function_subtype_bound_closure1_test': skip_fail,
       'function_subtype_bound_closure2_test': skip_fail,
       'function_subtype_bound_closure3_test': skip_fail,
       'function_subtype_bound_closure4_test': skip_fail,
       'function_subtype_bound_closure5_test': skip_fail,
@@ skipping 27 matching lines @@
       'function_subtype_typearg0_test': skip_fail,
       'function_subtype_typearg2_test': skip_fail,
       'function_subtype_typearg4_test': skip_fail,
       'function_type_alias2_test': skip_fail,
       'function_type_alias3_test': skip_fail,
       'function_type_alias4_test': skip_fail,
       'function_type_alias6_test_none_multi': skip_fail,
       'function_type_alias_test': skip_fail,
       'function_type_call_getter_test': skip_fail,
       'gc_test': skip_fail,
-      'generic2_test': skip_fail,
-      'generic_deep_test': skip_fail,
       'generic_field_mixin2_test': skip_fail,
       'generic_field_mixin3_test': skip_fail,
       'generic_field_mixin4_test': skip_fail,
       'generic_field_mixin5_test': skip_fail,
       'generic_field_mixin_test': skip_fail,
-      'generic_inheritance_test': skip_fail,
       'generic_instanceof2_test': skip_fail,
-      'generic_instanceof3_test': skip_fail,
-      'generic_instanceof_test': skip_fail,
       'generic_is_check_test': skip_fail,
-      'generic_native_test': skip_fail,
-      'generic_parameterized_extends_test': skip_fail,
       'getter_closure_execution_order_test': skip_fail,
       'getter_override2_test_00_multi': skip_fail,
       'getters_setters_test': skip_fail,
       'hash_code_mangling_test': skip_fail,
       'identical_closure2_test': skip_fail,
-      'if_null_behavior_test_14_multi': skip_fail,
       'infinite_switch_label_test': skip_fail,
       'infinity_test': skip_fail,
       'instance_creation_in_function_annotation_test': skip_fail,
-      'instanceof2_test': skip_fail,
-      'instanceof4_test_01_multi': skip_fail,
-      'instanceof4_test_none_multi': skip_fail,
+      'instanceof2_test': fail,
+      'instanceof4_test_01_multi': fail,
+      'instanceof4_test_none_multi': fail,
       'instanceof_optimized_test': skip_fail,
-      'int_test': skip_fail,
-      'integer_division_by_zero_test': skip_fail,
-      'interceptor_test': skip_fail,
-      'interceptor9_test': skip_fail,
-      'is_nan_test': skip_fail,
+      'integer_division_by_zero_test': fail,
+      'is_nan_test': fail,
       'issue10747_test': skip_fail,
       'issue13179_test': skip_fail,
       'issue21079_test': skip_fail,
       'issue21957_test': skip_fail,
       'issue_1751477_test': skip_fail,
       'issue_22780_test_01_multi': skip_fail,
       'issue_23914_test': skip_fail,
       'js_properties_test': skip_fail,
       'lazy_static3_test': skip_fail,
       'least_upper_bound_expansive_test_none_multi': skip_fail,
@@ skipping 16 matching lines @@
       'mixin_mixin5_test': skip_fail,
       'mixin_mixin6_test': skip_fail,
       'mixin_mixin7_test': skip_fail,
       'mixin_mixin_bound2_test': skip_fail,
       'mixin_mixin_bound_test': skip_fail,
       'mixin_mixin_test': skip_fail,
       'mixin_regress_13688_test': skip_fail,
       'mixin_type_parameter1_test': skip_fail,
       'mixin_type_parameter2_test': skip_fail,
       'mixin_type_parameter3_test': skip_fail,
-      'modulo_test': skip_fail,
-      'named_argument_test': skip_fail,
+      'modulo_test': fail,
       'named_parameter_clash_test': skip_fail,
-      'namer2_test': skip_fail,
       'nan_identical_test': skip_fail,
       'nested_switch_label_test': skip_fail,
       'no_such_method3_test': skip_fail,
-      'no_such_method_empty_selector_test': skip_fail,
+      'no_such_method_empty_selector_test': fail,
       'no_such_method_subtype_test': skip_fail,
-      'null_no_such_method_test': skip_fail,
       'number_identifier_test_05_multi': skip_fail,
       'number_identity2_test': skip_fail,
       'numbers_test': skip_fail,
-      'operator4_test': skip_fail,  // CastError instead of TypeError
       'optimized_hoisting_checked_mode_assert_test': skip_fail,
       'redirecting_factory_reflection_test': skip_fail,
       'regress_13462_0_test': skip_fail,
       'regress_13462_1_test': skip_fail,
       'regress_14105_test': skip_fail,
       'regress_16640_test': skip_fail,
       'regress_18535_test': skip_fail,
       'regress_21795_test': skip_fail,
       'regress_22443_test': skip_fail,
       'regress_22666_test': skip_fail,
-      'regress_22719_test': skip_fail,
-      'regress_23650_test': skip_fail,
-      'regress_r24720_test': skip_fail,
       'setter_no_getter_test_01_multi': skip_fail,
-      'smi_type_test': skip_fail,
       'stack_overflow_stacktrace_test': skip_fail,
       'stack_overflow_test': skip_fail,
       'stack_trace_test': skip_fail,
       'stacktrace_rethrow_nonerror_test': skip_fail, // mismatch from Karma's file hash
       'stacktrace_rethrow_error_test_none_multi': skip_fail,
       'stacktrace_rethrow_error_test_withtraceparameter_multi': skip_fail,
       'stacktrace_test': skip_fail,
       'string_interpolate_null_test': skip_fail,
-      'string_interpolation_newline_test': skip_fail,
       'super_field_2_test': skip_fail,
       'super_field_test': skip_fail,
       'super_operator_index3_test': skip_fail,
       'super_operator_index4_test': skip_fail,
       'switch_label2_test': skip_fail,
       'switch_label_test': skip_fail,
       'switch_try_catch_test': skip_fail,
       'sync_generator1_test_none_multi': skip_fail,
       'throwing_lazy_variable_test': skip_fail,
       'top_level_non_prefixed_library_test': skip_fail,
-      'truncdiv_test': skip_fail,
-      'type_argument_substitution_test': skip_fail,
-      'type_promotion_functions_test_none_multi': skip_fail,
-      'type_variable_closure2_test': skip_fail,
-      'type_variable_field_initializer_closure_test': skip_fail,
-      'type_variable_field_initializer_test': skip_fail,
-      'type_variable_nested_test': skip_fail,
-      'type_variable_typedef_test': skip_fail,
-      'typedef_is_test': skip_fail,
+      'truncdiv_test': fail,  // did not throw
+      'type_variable_nested_test': skip_fail,  // unsound is-check
+      'type_variable_typedef_test': skip_fail,  // unsound is-check
 
       'bit_operations_test_01_multi': skip_fail,
       'bit_operations_test_02_multi': skip_fail,
       'bit_operations_test_03_multi': skip_fail,
       'bit_operations_test_04_multi': skip_fail,
       'bool_condition_check_test_01_multi': skip_fail,
       'deferred_constraints_constants_test_none_multi': skip_fail,
       'deferred_constraints_constants_test_reference_after_load_multi': skip_fail,
       'deferred_constraints_type_annotation_test_new_generic1_multi': skip_fail,
       'deferred_constraints_type_annotation_test_new_multi': skip_fail,
@@ skipping 11 matching lines @@
       'multiline_newline_test_06_multi': skip_fail,
       'multiline_newline_test_none_multi': skip_fail,
       'no_main_test_01_multi': skip_fail,
 
       // https://github.com/dart-lang/sdk/issues/26123
       'bad_raw_string_negative_test': skip_fail,
 
       // https://github.com/dart-lang/sdk/issues/26124
       'prefix10_negative_test': skip_fail,
 
-      // TODO(vsm): Right shift should not propagate sign
-      // https://github.com/dart-lang/dev_compiler/issues/446
-      'float32x4_sign_mask_test': skip_fail,
-      'int32x4_sign_mask_test': skip_fail,
-
-      // TODO(vsm): Triage further
-      // exports._GeneratorIterable$ is not a function
-      'byte_data_test': skip_fail,
-      'endianness_test': skip_fail,
-
       'library_prefixes_test1': 'helper',
       'library_prefixes_test2': 'helper',
       'top_level_prefixed_library_test': 'helper',
     },
 
     'corelib': {
       'apply2_test': fail,
       'apply3_test': fail,
       'apply_test': fail,
       'big_integer_parsed_arith_vm_test': fail,
@@ skipping 423 matching lines @@
 
     for (let action of unittest_tests) {
       try {
         action();
       } catch (e) {
         console.error("Caught error tying to setup test:", e);
       }
     }
   });
 })();