Throw TypeError instead of CastError for type coercions.

Throw TypeError instead of CastError for type coercions.

Added 'tag' type StrongModeError, implemented by all errors that are
specific to strong mode semantics.

Failed casts throw CastError(Implementation) or StrongModeCastError.
Failed type assertions and reified coercions throw TypeError or
StrongModeTypeError.

Triaged some tests. Some pass due to now throwing a TypeError, many
pass for unknown reasons.

R=leafp@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/1da73c61eeeb6efcc22b93839ce663c19dd3d19a

[sra1, 2016-05-31 23:06:09]

sra@google.com changed reviewers:
+ vsm@google.com

[sra1, 2016-05-31 23:09:51]

https://codereview.chromium.org/2026133002/diff/1/test/browser/language_tests.js
File test/browser/language_tests.js (right):

https://codereview.chromium.org/2026133002/diff/1/test/browser/language_tests...
test/browser/language_tests.js:36: //'arithmetic2_test': fail,
I will remove this

[sra1, 2016-06-01 16:43:41]

sra@google.com changed reviewers:
+ leafp@google.com

[Leaf, 2016-06-01 17:01:51]

lgtm

https://codereview.chromium.org/2026133002/diff/20001/tool/input_sdk/private/...
File tool/input_sdk/private/js_helper.dart (right):

https://codereview.chromium.org/2026133002/diff/20001/tool/input_sdk/private/...
tool/input_sdk/private/js_helper.dart:802: CastErrorImplementation(Object value,
Object actualType, Object expectedType)
Why the unused "value" parameter?

[sra1, 2016-06-01 17:07:13]

https://codereview.chromium.org/2026133002/diff/20001/tool/input_sdk/private/...
File tool/input_sdk/private/js_helper.dart (right):

https://codereview.chromium.org/2026133002/diff/20001/tool/input_sdk/private/...
tool/input_sdk/private/js_helper.dart:802: CastErrorImplementation(Object value,
Object actualType, Object expectedType)
On 2016/06/01 17:01:51, Leaf wrote:
> Why the unused "value" parameter?

I will add a TODO, but I would eventually like the exception to display the
value as well as its type.

[sra1, 2016-06-01 17:18:28]

Description was changed from

==========
Throw TypeError instead of CastError for type coercions.

Added 'tag' type StrongModeError, implemented by all errors that are
specific to strong mode semantics.

Failed casts throw CastError(Implementation) or StrongModeCastError.
Failed type assertions and reified coercions throw TypeError or
StrongModeTypeError.

Triaged some tests. Some pass due to now throwing a TypeError, many
pass for unknown reasons.
==========

to

==========
Throw TypeError instead of CastError for type coercions.

Added 'tag' type StrongModeError, implemented by all errors that are
specific to strong mode semantics.

Failed casts throw CastError(Implementation) or StrongModeCastError.
Failed type assertions and reified coercions throw TypeError or
StrongModeTypeError.

Triaged some tests. Some pass due to now throwing a TypeError, many
pass for unknown reasons.

R=leafp@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/1da73c61eeeb6efcc22b93839ce6...
==========

[sra1, 2016-06-01 17:18:29]

Committed patchset #2 (id:20001) manually as
1da73c61eeeb6efcc22b93839ce663c19dd3d19a (presubmit successful).