Issue 2026123003: Remove buildTopLevelFunctions() and resynthesize top-level functions directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2026123003: Remove buildTopLevelFunctions() and resynthesize top-level functions directly. (Closed)

Created:
4 years, 6 months ago by scheglov

Modified:
4 years, 6 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove buildTopLevelFunctions() and resynthesize top-level functions directly. The performance is OK despite the use of the where/map.toList chain. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/097b11ce0412502ff11bc7894f92c4b7453767d5

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -25 lines)			Patch
	M	pkg/analyzer/lib/src/dart/element/element.dart	View		2 chunks	+5 lines, -7 lines	0 comments	Download
	M	pkg/analyzer/lib/src/summary/resynthesize.dart	View		2 chunks	+0 lines, -18 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

Committed patchset #1 (id:1) manually as 097b11ce0412502ff11bc7894f92c4b7453767d5 (presubmit successful).

4 years, 6 months ago (2016-06-01 15:06:26 UTC) #4

Message was sent while issue was closed.

lgtm