Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: remoting/protocol/jingle_messages.h

Issue 2026123002: [Chromoting] Use google:remoting namespace to export remoting specific error codes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/errors.cc ('k') | remoting/protocol/jingle_messages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/jingle_messages.h
diff --git a/remoting/protocol/jingle_messages.h b/remoting/protocol/jingle_messages.h
index 5dfe5124fbb8f2cec49262ecc53ceb185c676771..08e538a8a6a576653a2e0e4cd08fbfb300519f0c 100644
--- a/remoting/protocol/jingle_messages.h
+++ b/remoting/protocol/jingle_messages.h
@@ -9,6 +9,7 @@
#include <memory>
#include <string>
+#include "remoting/protocol/errors.h"
#include "third_party/webrtc/libjingle/xmllite/xmlelement.h"
#include "third_party/webrtc/p2p/base/candidate.h"
@@ -67,7 +68,6 @@ struct JingleMessage {
GENERAL_ERROR,
FAILED_APPLICATION,
INCOMPATIBLE_PARAMETERS,
- SECURITY_ERROR,
};
@@ -105,6 +105,11 @@ struct JingleMessage {
// message. Useful mainly for session-terminate messages, but Jingle
// spec allows it in any message.
Reason reason = UNKNOWN_REASON;
+
+ // Value from the <google:remoting:error-code> tag if it is present in the
+ // message. Useful mainly for session-terminate messages. If it's UNKNOWN,
+ // or reason is UNKNOWN_REASON, this field will be ignored in the xml output.
+ ErrorCode error_code = UNKNOWN_ERROR;
};
struct JingleMessageReply {
« no previous file with comments | « remoting/protocol/errors.cc ('k') | remoting/protocol/jingle_messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698