Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1976)

Unified Diff: remoting/protocol/errors.h

Issue 2026123002: [Chromoting] Use google:remoting namespace to export remoting specific error codes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/protocol/errors.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/errors.h
diff --git a/remoting/protocol/errors.h b/remoting/protocol/errors.h
index da9db8aa264762d60130eb6004b5cd521eff7c00..6a9dfd5d3e6535ffd07268445572a0b9659b2e03 100644
--- a/remoting/protocol/errors.h
+++ b/remoting/protocol/errors.h
@@ -5,12 +5,15 @@
#ifndef REMOTING_PROTOCOL_ERROR_H_
#define REMOTING_PROTOCOL_ERROR_H_
+#include <string>
+
namespace remoting {
namespace protocol {
// The UI implementations maintain corresponding definitions of this
-// enumeration in webapp/error.js and
-// android/java/src/org/chromium/chromoting/jni/JniInterface.java.
+// enumeration in webapp/base/js/error.js, webapp/base/js/chromoting_event.js,
+// android/java/src/org/chromium/chromoting/jni/ConnectionListener.java and
+// remoting/protocol/errors.cc.
// Be sure to update these locations if you make any changes to the ordering.
enum ErrorCode {
OK = 0,
@@ -30,6 +33,8 @@ enum ErrorCode {
ERROR_CODE_MAX = UNKNOWN_ERROR,
};
+bool ParseErrorCode(const std::string& name, ErrorCode* result);
+
// Returns the literal string of |error|.
const char* ErrorCodeToString(ErrorCode error);
« no previous file with comments | « no previous file | remoting/protocol/errors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698