[Chromoting] Use google:remoting namespace to export remoting specific error codes

remoting/protocol/jingle_messages_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/jingle_messages.h"
 
 #include <stddef.h>
 
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 548 matching lines @@
   ASSERT_TRUE(source_message.get());
 
   EXPECT_FALSE(JingleMessage::IsJingleMessage(source_message.get()));
 
   JingleMessage message;
   std::string error;
   EXPECT_FALSE(message.ParseXml(source_message.get(), &error));
   EXPECT_FALSE(error.empty());
 }
 
+TEST(JingleMessageTest, ErrorCodeShouldBeIncludedInXml) {
+  JingleMessage message(std::string("to_jid"),
+                        JingleMessage::SESSION_TERMINATE,
+                        std::string("sid"));
+  message.action = JingleMessage::SESSION_TERMINATE;
+  message.reason = JingleMessage::DECLINE;
+  message.error_code = INVALID_ACCOUNT;
+  JingleMessage parsed;
+  ParseFormatAndCompare(message.ToXml()->Str().c_str(), &parsed);

[Sergey Ulanov, 2016/06/03 08:53:49]

This tests formats message, parses it and then formats again. I'm not sure
what's the point. Can this test works the same way as all other tests: Parse
static XML blob and then format it again?

[Hzj_jie, 2016/06/03 21:46:34]

This test was for debugging purpose, I should remove it.

+  EXPECT_EQ(message.action, parsed.action);
+  EXPECT_EQ(message.reason, parsed.reason);
+  EXPECT_EQ(message.error_code, parsed.error_code);
+
+  message.error_code = UNKNOWN_ERROR;
+  parsed.error_code = UNKNOWN_ERROR;
+  ParseFormatAndCompare(message.ToXml()->Str().c_str(), &parsed);
+  EXPECT_EQ(message.action, parsed.action);
+  EXPECT_EQ(message.reason, parsed.reason);
+  EXPECT_EQ(UNKNOWN_ERROR, parsed.error_code);

[Sergey Ulanov, 2016/06/03 08:53:49]

Add this condition in the SessionTerminate test above and then you wouldn't need
to test this case here. 

[Hzj_jie, 2016/06/03 21:46:33]

Acknowledged.

+}
+
+TEST(JingleMessageTest, InvalidAccount) {
+  const char* kTestSessionTerminateMessage =
+      "<cli:iq from='user@gmail.com/chromoting016DBB07' "
+      "to='user@gmail.com/chromiumsy5C6A652D' type='set' "
+      "xmlns:cli='jabber:client'><jingle action='session-terminate' "
+      "sid='2227053353' xmlns='urn:xmpp:jingle:1'><reason><decline/></reason>"
+      "<gr:error-code xmlns:gr='google:remoting'>"
+        "<gr:INVALID_ACCOUNT/>"
+      "</gr:error-code>"
+      "</jingle></cli:iq>";
+  JingleMessage message;
+  ParseFormatAndCompare(kTestSessionTerminateMessage, &message);
+  EXPECT_EQ(message.action, JingleMessage::SESSION_TERMINATE);
+  EXPECT_EQ(message.reason, JingleMessage::DECLINE);
+  EXPECT_EQ(message.error_code, INVALID_ACCOUNT);
+}
+
+TEST(JingleMessageTest, AuthenticationFailed) {

[Sergey Ulanov, 2016/06/03 08:53:49]

Maybe instead of testing these two errors in two separate tests add a single
tests that iterates over all possible error codes and verifies that each of them
gets handled properly (ie. for each error code create JingleMessage, format it,
parse it, check that you get the right result on the output).

[Hzj_jie, 2016/06/03 21:46:34]

Done.

+  const char* kTestSessionTerminateMessage =
+      "<cli:iq from='user@gmail.com/chromoting016DBB07' "
+      "to='user@gmail.com/chromiumsy5C6A652D' type='set' "
+      "xmlns:cli='jabber:client'><jingle action='session-terminate' "
+      "sid='2227053353' xmlns='urn:xmpp:jingle:1'><reason><decline/></reason>"
+      "<gr:error-code xmlns:gr='google:remoting'>"
+        "<gr:AUTHENTICATION_FAILED />"
+      "</gr:error-code>"
+      "</jingle></cli:iq>";
+  JingleMessage message;
+  ParseFormatAndCompare(kTestSessionTerminateMessage, &message);
+  EXPECT_EQ(message.action, JingleMessage::SESSION_TERMINATE);
+  EXPECT_EQ(message.reason, JingleMessage::DECLINE);
+  EXPECT_EQ(message.error_code, AUTHENTICATION_FAILED);
+}
+
 }  // namespace protocol
 }  // namespace remoting