[Chromoting] Use google:remoting namespace to export remoting specific error codes

remoting/protocol/jingle_messages_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/jingle_messages.h"
 
 #include <stddef.h>
 
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 548 matching lines @@
   ASSERT_TRUE(source_message.get());
 
   EXPECT_FALSE(JingleMessage::IsJingleMessage(source_message.get()));
 
   JingleMessage message;
   std::string error;
   EXPECT_FALSE(message.ParseXml(source_message.get(), &error));
   EXPECT_FALSE(error.empty());
 }
 
+TEST(JingleMessageTest, ErrorCodeShouldBeIncludedInXml) {
+  JingleMessage message(std::string("to_jid"),
+                        JingleMessage::SESSION_TERMINATE,
+                        std::string("sid"));
+  message.action = JingleMessage::SESSION_TERMINATE;
+  message.reason = JingleMessage::DECLINE;
+  message.error_code = INVALID_ACCOUNT;
+  EXPECT_EQ(message.ToXml()->Str(),

[Sergey Ulanov, 2016/06/02 09:26:04]

You don't want to compare generate XML as string. Tests like this are unstable
because they are easily broken with small changes in the XML formatter. Tests
above use VerifyXml() to compare generated XML with expected value.

[Hzj_jie, 2016/06/02 22:00:18]

Done.

+      "<iq xmlns=\"jabber:client\" to=\"to_jid\" type=\"set\">"
+        "<jingle xmlns=\"urn:xmpp:jingle:1\" sid=\"sid\" "
+        "action=\"session-terminate\">"
+          "<reason><decline/></reason>"
+          "<rem:error-code xmlns:rem=\"google:remoting\">"
+            "<rem:INVALID_ACCOUNT/>"
+          "</rem:error-code>"
+        "</jingle>"
+      "</iq>");
+  JingleMessage parsed;
+  ParseFormatAndCompare(message.ToXml()->Str().c_str(), &parsed);
+  EXPECT_EQ(message.action, parsed.action);
+  EXPECT_EQ(message.reason, parsed.reason);
+  EXPECT_EQ(message.error_code, parsed.error_code);
+
+  message.error_code = parsed.error_code = UNKNOWN_ERROR;

[Sergey Ulanov, 2016/06/02 09:26:04]

this double assignment is not readable. Please split it into two lines.

[Hzj_jie, 2016/06/02 22:00:19]

Done.

+  EXPECT_EQ(message.ToXml()->Str(),
+      "<iq xmlns=\"jabber:client\" to=\"to_jid\" type=\"set\">"
+        "<jingle xmlns=\"urn:xmpp:jingle:1\" sid=\"sid\" "
+        "action=\"session-terminate\">"
+          "<reason><decline/></reason>"
+        "</jingle>"
+      "</iq>");
+  ParseFormatAndCompare(message.ToXml()->Str().c_str(), &parsed);
+  EXPECT_EQ(message.action, parsed.action);
+  EXPECT_EQ(message.reason, parsed.reason);
+}
+
+TEST(JingleMessageTest, InvalidAccount) {
+  const char* kTestSessionTerminateMessage =
+      "<cli:iq from='user@gmail.com/chromoting016DBB07' "
+      "to='user@gmail.com/chromiumsy5C6A652D' type='set' "
+      "xmlns:cli='jabber:client'><jingle action='session-terminate' "
+      "sid='2227053353' xmlns='urn:xmpp:jingle:1'><reason><decline/></reason>"
+      "<gr:error-code xmlns:gr='google:remoting'>"
+        "<gr:INVALID_ACCOUNT/>"
+      "</gr:error-code>"
+      "</jingle></cli:iq>";
+  JingleMessage message;
+  ParseFormatAndCompare(kTestSessionTerminateMessage, &message);
+  EXPECT_EQ(message.action, JingleMessage::SESSION_TERMINATE);
+  EXPECT_EQ(message.reason, JingleMessage::DECLINE);
+  EXPECT_EQ(message.error_code, INVALID_ACCOUNT);
+}
+
+TEST(JingleMessageTest, AuthenticationFailed) {
+  const char* kTestSessionTerminateMessage =
+      "<cli:iq from='user@gmail.com/chromoting016DBB07' "
+      "to='user@gmail.com/chromiumsy5C6A652D' type='set' "
+      "xmlns:cli='jabber:client'><jingle action='session-terminate' "
+      "sid='2227053353' xmlns='urn:xmpp:jingle:1'><reason><decline/></reason>"
+      "<gr:error-code xmlns:gr='google:remoting'>"
+        "<gr:AUTHENTICATION_FAILED />"
+      "</gr:error-code>"
+      "</jingle></cli:iq>";
+  JingleMessage message;
+  ParseFormatAndCompare(kTestSessionTerminateMessage, &message);
+  EXPECT_EQ(message.action, JingleMessage::SESSION_TERMINATE);
+  EXPECT_EQ(message.reason, JingleMessage::DECLINE);
+  EXPECT_EQ(message.error_code, AUTHENTICATION_FAILED);
+}
+
 }  // namespace protocol
 }  // namespace remoting