[Chromoting] Use google:remoting namespace to export remoting specific error codes

remoting/protocol/jingle_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_JINGLE_MESSAGES_H_
 #define REMOTING_PROTOCOL_JINGLE_MESSAGES_H_
 
 #include <list>
 #include <memory>
 #include <string>
@@ skipping 49 matching lines @@
 
   enum Reason {
     UNKNOWN_REASON,
     SUCCESS,
     DECLINE,
     CANCEL,
     EXPIRED,
     GENERAL_ERROR,
     FAILED_APPLICATION,
     INCOMPATIBLE_PARAMETERS,
-    SECURITY_ERROR,
+  };
+
+  // Remoting specific error codes to fill the gap between Jingle errors and CRD
+  // errors.
+  enum struct ErrorCode {

[Sergey Ulanov, 2016/06/01 08:52:47]

I don't think we want to add another enum to represent errors. Just use
remoting::protocol::ErrorCode

[Hzj_jie, 2016/06/01 23:56:13]

Done.

+    UNKNOWN,
+    SESSION_REJECTED,
+    AUTHENTICATION_FAILED,
+    INVALID_ACCOUNT,
   };
 
 
   JingleMessage();
   JingleMessage(const SignalingAddress& to,
                 ActionType action_value,
                 const std::string& sid_value);
   ~JingleMessage();
 
   // Caller keeps ownership of |stanza|.
@@ skipping 17 matching lines @@
 
   std::unique_ptr<buzz::XmlElement> transport_info;
 
   // Content of session-info messages.
   std::unique_ptr<buzz::XmlElement> info;
 
   // Value from the <reason> tag if it is present in the
   // message. Useful mainly for session-terminate messages, but Jingle
   // spec allows it in any message.
   Reason reason = UNKNOWN_REASON;
+
+  // Value from the <google:remoting:error-code> tag if it is present in the
+  // message. Useful mainly for session-terminate messages. If it's UNKNOWN,
+  // or reason is UNKNOWN_REASON, this field will be ignored in the xml output.
+  ErrorCode error_code = ErrorCode::UNKNOWN;
 };
 
 struct JingleMessageReply {
   enum ReplyType {
     REPLY_RESULT,
     REPLY_ERROR,
   };
   enum ErrorType {
     NONE,
     BAD_REQUEST,
@@ skipping 48 matching lines @@
   std::unique_ptr<buzz::XmlElement> ToXml() const;
 
   std::list<IceCredentials> ice_credentials;
   std::list<NamedCandidate> candidates;
 };
 
 }  // protocol
 }  // remoting
 
 #endif  // REMOTING_PROTOCOL_JINGLE_MESSAGES_H_