Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2026073002: Restore epsilon tolerance in LineWidth (Closed)

Created:
4 years, 6 months ago by eae
Modified:
4 years, 6 months ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore epsilon tolerance in LineWidth Restore the LayoutUnit::epsilon tolerance in LineWidth::fitsOnLine calls to avoid unnecessary breaks at element boundaries due to precision loss. R=szager@chromium.org BUG=613118 TEST=fast/text/sub-pixel/button-span-wrap.html Committed: https://crrev.com/d501ee220d6edaf83e98815945e3fca7766f43dd Cr-Commit-Position: refs/heads/master@{#397185}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/sub-pixel/button-span-wrap.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/sub-pixel/button-span-wrap-expected.html View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineWidth.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eae
Temporarily restoring the epilon hack to fix a release blocker.
4 years, 6 months ago (2016-05-31 21:19:05 UTC) #1
szager1
lgtm :(
4 years, 6 months ago (2016-06-01 07:02:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026073002/20001
4 years, 6 months ago (2016-06-01 16:09:53 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 18:06:23 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 18:07:35 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d501ee220d6edaf83e98815945e3fca7766f43dd
Cr-Commit-Position: refs/heads/master@{#397185}

Powered by Google App Engine
This is Rietveld 408576698