Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: blimp/client/feature/render_widget_feature.cc

Issue 2026053002: Blimp: change logger to use switch/case for types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | blimp/common/logging.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/feature/render_widget_feature.h" 5 #include "blimp/client/feature/render_widget_feature.h"
6 6
7 #include "base/numerics/safe_conversions.h" 7 #include "base/numerics/safe_conversions.h"
8 #include "blimp/common/create_blimp_message.h" 8 #include "blimp/common/create_blimp_message.h"
9 #include "blimp/common/proto/blimp_message.pb.h" 9 #include "blimp/common/proto/blimp_message.pb.h"
10 #include "blimp/common/proto/compositor.pb.h" 10 #include "blimp/common/proto/compositor.pb.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 93
94 switch (message->feature_case()) { 94 switch (message->feature_case()) {
95 case BlimpMessage::kRenderWidget: 95 case BlimpMessage::kRenderWidget:
96 ProcessRenderWidgetMessage(delegate, message->render_widget()); 96 ProcessRenderWidgetMessage(delegate, message->render_widget());
97 break; 97 break;
98 case BlimpMessage::kCompositor: 98 case BlimpMessage::kCompositor:
99 ProcessCompositorMessage(delegate, message->compositor()); 99 ProcessCompositorMessage(delegate, message->compositor());
100 break; 100 break;
101 default: 101 default:
102 NOTREACHED(); 102 NOTREACHED();
103 break;
103 } 104 }
104 105
105 callback.Run(net::OK); 106 callback.Run(net::OK);
106 } 107 }
107 108
108 void RenderWidgetFeature::ProcessRenderWidgetMessage( 109 void RenderWidgetFeature::ProcessRenderWidgetMessage(
109 RenderWidgetFeatureDelegate* delegate, 110 RenderWidgetFeatureDelegate* delegate,
110 const RenderWidgetMessage& message) { 111 const RenderWidgetMessage& message) {
111 int render_widget_id = message.render_widget_id(); 112 int render_widget_id = message.render_widget_id();
112 113
113 switch (message.type()) { 114 switch (message.type()) {
114 case RenderWidgetMessage::CREATED: 115 case RenderWidgetMessage::CREATED:
115 delegate->OnRenderWidgetCreated(render_widget_id); 116 delegate->OnRenderWidgetCreated(render_widget_id);
116 break; 117 break;
117 case RenderWidgetMessage::INITIALIZE: 118 case RenderWidgetMessage::INITIALIZE:
118 delegate->OnRenderWidgetInitialized(render_widget_id); 119 delegate->OnRenderWidgetInitialized(render_widget_id);
119 break; 120 break;
120 case RenderWidgetMessage::DELETED: 121 case RenderWidgetMessage::DELETED:
121 delegate->OnRenderWidgetDeleted(render_widget_id); 122 delegate->OnRenderWidgetDeleted(render_widget_id);
122 break; 123 break;
124 case RenderWidgetMessage::UNKNOWN:
125 NOTREACHED();
126 break;
123 } 127 }
124 } 128 }
125 129
126 void RenderWidgetFeature::ProcessCompositorMessage( 130 void RenderWidgetFeature::ProcessCompositorMessage(
127 RenderWidgetFeatureDelegate* delegate, 131 RenderWidgetFeatureDelegate* delegate,
128 const CompositorMessage& message) { 132 const CompositorMessage& message) {
129 int render_widget_id = message.render_widget_id(); 133 int render_widget_id = message.render_widget_id();
130 134
131 std::unique_ptr<cc::proto::CompositorMessage> payload( 135 std::unique_ptr<cc::proto::CompositorMessage> payload(
132 new cc::proto::CompositorMessage); 136 new cc::proto::CompositorMessage);
133 if (payload->ParseFromString(message.payload())) { 137 if (payload->ParseFromString(message.payload())) {
134 delegate->OnCompositorMessageReceived(render_widget_id, 138 delegate->OnCompositorMessageReceived(render_widget_id,
135 std::move(payload)); 139 std::move(payload));
136 } 140 }
137 } 141 }
138 142
139 RenderWidgetFeature::RenderWidgetFeatureDelegate* 143 RenderWidgetFeature::RenderWidgetFeatureDelegate*
140 RenderWidgetFeature::FindDelegate(const int tab_id) { 144 RenderWidgetFeature::FindDelegate(const int tab_id) {
141 DelegateMap::const_iterator it = delegates_.find(tab_id); 145 DelegateMap::const_iterator it = delegates_.find(tab_id);
142 if (it != delegates_.end()) 146 if (it != delegates_.end())
143 return it->second; 147 return it->second;
144 return nullptr; 148 return nullptr;
145 } 149 }
146 150
147 } // namespace client 151 } // namespace client
148 } // namespace blimp 152 } // namespace blimp
OLDNEW
« no previous file with comments | « no previous file | blimp/common/logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698