cc: Remove can_use_lcd_text from draw properties

cc: Remove can_use_lcd_text from draw properties

The lcd text is only updated at commit time. We should compute whether
or not to use_lcd_text on demand rather than updating it every frame.

BUG=581842
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5a7a40314dca3ebb0ac625f839abfaab115ae496
Cr-Commit-Position: refs/heads/master@{#397194}

[sunxd, 2016-05-31 20:11:09]

Description was changed from

==========
cc: Remove can_use_lcd_text from draw properties

The lcd text is only updated at commit time. We should compute whether
or not to use_lcd_text on demand rather than updating it every frame.

BUG=581842
==========

to

==========
cc: Remove can_use_lcd_text from draw properties

The lcd text is only updated at commit time. We should compute whether
or not to use_lcd_text on demand rather than updating it every frame.

BUG=581842
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunxd, 2016-06-01 14:26:49]

sunxd@chromium.org changed reviewers:
+ ajuma@chromium.org, jaydasika@chromium.org, vollick@chromium.org,
weiliangc@chromium.org

[ajuma, 2016-06-01 15:38:38]

Nice! Just one nit:

https://codereview.chromium.org/2026033002/diff/1/cc/layers/layer_impl.h
File cc/layers/layer_impl.h (right):

https://codereview.chromium.org/2026033002/diff/1/cc/layers/layer_impl.h#newc...
cc/layers/layer_impl.h:322: bool can_use_lcd_text() const;
Style nit: Since this isn't "simple" any more, it needs to be renamed to
CanUseLcdText.

[sunxd, 2016-06-01 15:54:48]

I rename it to CanUseLCDText as there is a LCDTextTest in
layer_tree_host_common_unittest.cc.

https://codereview.chromium.org/2026033002/diff/1/cc/layers/layer_impl.h
File cc/layers/layer_impl.h (right):

https://codereview.chromium.org/2026033002/diff/1/cc/layers/layer_impl.h#newc...
cc/layers/layer_impl.h:322: bool can_use_lcd_text() const;
On 2016/06/01 15:38:38, ajuma wrote:
> Style nit: Since this isn't "simple" any more, it needs to be renamed to
> CanUseLcdText.

Done.

[ajuma, 2016-06-01 16:51:20]

Thanks, lgtm

[sunxd, 2016-06-01 17:27:02]

The CQ bit was checked by sunxd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 17:27:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026033002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026033002/40001

[commit-bot: I haz the power, 2016-06-01 18:37:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 18:37:02]

Dry run: This issue passed the CQ dry run.

[sunxd, 2016-06-01 18:43:49]

The CQ bit was checked by sunxd@chromium.org

[sunxd, 2016-06-01 18:43:50]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2026033002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-01 18:44:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026033002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026033002/40001

[commit-bot: I haz the power, 2016-06-01 18:49:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-01 19:11:42]

Description was changed from

==========
cc: Remove can_use_lcd_text from draw properties

The lcd text is only updated at commit time. We should compute whether
or not to use_lcd_text on demand rather than updating it every frame.

BUG=581842
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Remove can_use_lcd_text from draw properties

The lcd text is only updated at commit time. We should compute whether
or not to use_lcd_text on demand rather than updating it every frame.

BUG=581842
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5a7a40314dca3ebb0ac625f839abfaab115ae496
Cr-Commit-Position: refs/heads/master@{#397194}
==========

[commit-bot: I haz the power, 2016-06-01 19:11:43]

Patchset 3 (id:??) landed as
https://crrev.com/5a7a40314dca3ebb0ac625f839abfaab115ae496
Cr-Commit-Position: refs/heads/master@{#397194}