Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2026023002: Add/update history strings for iOS native history (Closed)

Created:
4 years, 6 months ago by Jackie Quinn
Modified:
4 years, 6 months ago
Reviewers:
stkhapugin, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add/update history strings for iOS native history Add "Clear Browsing Data..." titlecase string variant and edit, delete, and cancel button text for iOS native history UI edit mode. BUG=616226 Committed: https://crrev.com/b2636d175121d018e4d87c9d6c1f8574e239fb86 Cr-Commit-Position: refs/heads/master@{#397138}

Patch Set 1 #

Patch Set 2 : more strings #

Patch Set 3 : strings update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M components/history_strings.grdp View 1 2 4 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Jackie Quinn
4 years, 6 months ago (2016-05-31 22:55:35 UTC) #5
sdefresne
lgtm
4 years, 6 months ago (2016-06-01 08:05:45 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026023002/40001
4 years, 6 months ago (2016-06-01 14:11:20 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 14:50:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026023002/40001
4 years, 6 months ago (2016-06-01 14:52:33 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-01 14:56:17 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 14:58:06 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b2636d175121d018e4d87c9d6c1f8574e239fb86
Cr-Commit-Position: refs/heads/master@{#397138}

Powered by Google App Engine
This is Rietveld 408576698