Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 20260: Issue 87: Allow unicode escapes in regexp flags. (Closed)

Created:
11 years, 10 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Regular Expression literal flags may contain unicode escapes. If these escape any of the valid flags, "gim", they should work.

Patch Set 1 #

Patch Set 2 : Now with test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -3 lines) Patch
M src/parser.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/scanner.cc View 2 chunks +12 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-87.js View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Small review, please.
11 years, 10 months ago (2009-02-11 13:14:33 UTC) #1
Christian Plesner Hansen
11 years, 10 months ago (2009-02-11 13:22:36 UTC) #2
Lgtm!

Powered by Google App Engine
This is Rietveld 408576698