MacViews: Treat Ctrl+LeftClick as RightClick on Mac.

ui/events/cocoa/events_mac_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 #include <stdint.h>
 
 #include <memory>
 
 #include "base/mac/scoped_cftyperef.h"
@@ skipping 135 matching lines @@
   // Caps + Left
   NSEvent* caps = cocoa_test_event_utils::MouseEventWithType(
       NSLeftMouseUp, NSAlphaShiftKeyMask);
   EXPECT_EQ(EF_LEFT_MOUSE_BUTTON | EF_CAPS_LOCK_ON, EventFlagsFromNative(caps));
 
   // Shift + Left
   NSEvent* shift = cocoa_test_event_utils::MouseEventWithType(NSLeftMouseUp,
                                                               NSShiftKeyMask);
   EXPECT_EQ(EF_LEFT_MOUSE_BUTTON | EF_SHIFT_DOWN, EventFlagsFromNative(shift));
 
-  // Ctrl + Left
+  // Ctrl + Left. Note we map this to a right click on Mac.
   NSEvent* ctrl = cocoa_test_event_utils::MouseEventWithType(NSLeftMouseUp,
                                                              NSControlKeyMask);
-  EXPECT_EQ(EF_LEFT_MOUSE_BUTTON | EF_CONTROL_DOWN, EventFlagsFromNative(ctrl));
+  EXPECT_EQ(EF_RIGHT_MOUSE_BUTTON | EF_CONTROL_DOWN,

[Nico, 2016/06/02 11:22:45]

Ctrl-left probably should be right without ctrl (?)

[tapted, 2016/06/03 01:25:04]

Done. I couldn't decide which :). If it was Cmd, or Middle-Click there's
questions around open disposition, but Ctrl-clicks on Mac seem to be exclusively
for this right-click thing, so nothing thinks to check for ctrl.

+            EventFlagsFromNative(ctrl));
+
+  // Ctrl + Right. Remains a right click.
+  NSEvent* ctrl_right = cocoa_test_event_utils::MouseEventWithType(
+      NSRightMouseUp, NSControlKeyMask);
+  EXPECT_EQ(EF_RIGHT_MOUSE_BUTTON | EF_CONTROL_DOWN,
+            EventFlagsFromNative(ctrl_right));
 
   // Alt + Left
   NSEvent* alt = cocoa_test_event_utils::MouseEventWithType(NSLeftMouseUp,
                                                             NSAlternateKeyMask);
   EXPECT_EQ(EF_LEFT_MOUSE_BUTTON | EF_ALT_DOWN, EventFlagsFromNative(alt));
 
   // Cmd + Left
   NSEvent* cmd = cocoa_test_event_utils::MouseEventWithType(NSLeftMouseUp,
                                                             NSCommandKeyMask);
   EXPECT_EQ(EF_LEFT_MOUSE_BUTTON | EF_COMMAND_DOWN, EventFlagsFromNative(cmd));
 
-  // Shift + Ctrl + Left
+  // Shift + Ctrl + Left. Also mapped to a right-click.
   NSEvent* shiftctrl = cocoa_test_event_utils::MouseEventWithType(
       NSLeftMouseUp, NSShiftKeyMask | NSControlKeyMask);
-  EXPECT_EQ(EF_LEFT_MOUSE_BUTTON | EF_SHIFT_DOWN | EF_CONTROL_DOWN,
+  EXPECT_EQ(EF_RIGHT_MOUSE_BUTTON | EF_SHIFT_DOWN | EF_CONTROL_DOWN,
             EventFlagsFromNative(shiftctrl));
 
   // Cmd + Alt + Right
   NSEvent* cmdalt = cocoa_test_event_utils::MouseEventWithType(
       NSLeftMouseUp, NSCommandKeyMask | NSAlternateKeyMask);
   EXPECT_EQ(EF_LEFT_MOUSE_BUTTON | EF_COMMAND_DOWN | EF_ALT_DOWN,
             EventFlagsFromNative(cmdalt));
 }
 
 // Tests mouse button presses and mouse wheel events.
@@ skipping 124 matching lines @@
   event = cocoa_test_event_utils::MouseEventWithType(NSMouseMoved, 0);
   EXPECT_EQ(ui::ET_MOUSE_MOVED, ui::EventTypeFromNative(event));
 
   event = cocoa_test_event_utils::EnterEvent();
   EXPECT_EQ(ui::ET_MOUSE_ENTERED, ui::EventTypeFromNative(event));
   event = cocoa_test_event_utils::ExitEvent();
   EXPECT_EQ(ui::ET_MOUSE_EXITED, ui::EventTypeFromNative(event));
 }
 
 }  // namespace ui