Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2025893003: Clean up some dead code accidentally left around in cc DisplayItem subtypes. (Closed)

Created:
4 years, 6 months ago by chrishtr
Modified:
4 years, 6 months ago
Reviewers:
ajuma
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up some dead code accidentally left around in cc DisplayItem subtypes. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/dde161645aa4b06c4a12ad3641a7d7cf978de45a Cr-Commit-Position: refs/heads/master@{#396935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M cc/playback/clip_display_item.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/playback/clip_path_display_item.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/playback/compositing_display_item.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/playback/filter_display_item.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/playback/float_clip_display_item.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/playback/transform_display_item.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
chrishtr
4 years, 6 months ago (2016-05-31 19:50:47 UTC) #4
ajuma
lgtm
4 years, 6 months ago (2016-05-31 19:59:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025893003/1
4 years, 6 months ago (2016-05-31 19:59:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 21:35:24 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 21:36:49 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dde161645aa4b06c4a12ad3641a7d7cf978de45a
Cr-Commit-Position: refs/heads/master@{#396935}

Powered by Google App Engine
This is Rietveld 408576698