Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2025883002: [MIPS] Fix issue with sysroot_ld_path.py returning empty string (Closed)

Created:
4 years, 6 months ago by lmilko
Modified:
4 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, petar.jovanovic, gordana.cmiljanovic_imgtec.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MIPS] Fix issue with sysroot_ld_path.py returning empty string This change fixes ld.bfd failure when GN is used, which was caused by missing "-Wl,-rpath-link=" path. BUG=616082 TEST=Build Chromium for Linux MIPS using ld.bfd and GN Committed: https://crrev.com/75522f446b904fb6a68ed38a02ed4ff8aa321188 Cr-Commit-Position: refs/heads/master@{#397086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M build/config/posix/BUILD.gn View 1 chunk +7 lines, -7 lines 0 comments Download
M build/config/posix/sysroot_ld_path.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
lmilko
More details are in issue https://bugs.chromium.org/p/chromium/issues/detail?id=616082 Please take a look.
4 years, 6 months ago (2016-05-31 13:41:29 UTC) #2
brettw
lgtm
4 years, 6 months ago (2016-05-31 19:29:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025883002/1
4 years, 6 months ago (2016-06-01 07:51:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 08:55:15 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 08:57:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75522f446b904fb6a68ed38a02ed4ff8aa321188
Cr-Commit-Position: refs/heads/master@{#397086}

Powered by Google App Engine
This is Rietveld 408576698