Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: pkg/compiler/lib/src/compile_time_constants.dart

Issue 2025853002: Introduces "--initializing-formal-access". (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Eliminated unnecessary changes, thus avoiding 35 failing tests. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/commandline_options.dart ('k') | pkg/compiler/lib/src/dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/compile_time_constants.dart
diff --git a/pkg/compiler/lib/src/compile_time_constants.dart b/pkg/compiler/lib/src/compile_time_constants.dart
index 9bab3a5f51368b109edcb5962d8032a682c56d44..e5626dc5196b7d9f7db2c22a1f9c7c3518ed1537 100644
--- a/pkg/compiler/lib/src/compile_time_constants.dart
+++ b/pkg/compiler/lib/src/compile_time_constants.dart
@@ -1182,6 +1182,9 @@ class ConstructorEvaluator extends CompileTimeConstantEvaluator {
if (parameter.isInitializingFormal) {
InitializingFormalElement initializingFormal = parameter;
updateFieldValue(node, initializingFormal.fieldElement, argument);
+ if (compiler.options.enableInitializingFormalAccess) {
+ definitions[parameter] = argument;
+ }
} else {
potentiallyCheckType(parameter, argument);
definitions[parameter] = argument;
« no previous file with comments | « pkg/compiler/lib/src/commandline_options.dart ('k') | pkg/compiler/lib/src/dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698