Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2025833002: [heap] Store the host address in the typed remembered set. (Closed)

Created:
4 years, 6 months ago by ahaas
Modified:
4 years, 6 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Store the host address in the typed remembered set. We need the host address in another CL to clear invalid slots. R=ulan@chromium.org Committed: https://crrev.com/ae521505c44f631bbec9434cceeb2a85f76c1a92 Cr-Commit-Position: refs/heads/master@{#36696}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix compilation error on windows. #

Patch Set 4 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -25 lines) Patch
M src/heap/heap.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 chunks +9 lines, -5 lines 0 comments Download
M src/heap/remembered-set.h View 3 chunks +11 lines, -4 lines 0 comments Download
M src/heap/slot-set.h View 1 5 chunks +31 lines, -11 lines 0 comments Download
M test/unittests/heap/slot-set-unittest.cc View 1 2 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ahaas
4 years, 6 months ago (2016-05-31 09:15:06 UTC) #1
ulan
LGTM, could you please check that there is no regression benchmarks before landing? tools/try_perf.py --arm32 ...
4 years, 6 months ago (2016-06-01 09:05:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025833002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025833002/60001
4 years, 6 months ago (2016-06-03 08:29:35 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-03 08:31:01 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 08:31:16 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ae521505c44f631bbec9434cceeb2a85f76c1a92
Cr-Commit-Position: refs/heads/master@{#36696}

Powered by Google App Engine
This is Rietveld 408576698