Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/base/files/file.cc

Issue 202583005: Revert 257562 "Base: Make base::File use ScopedFD on POSIX." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/base/files/file.h ('k') | trunk/src/base/files/file_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/base/files/file.cc
===================================================================
--- trunk/src/base/files/file.cc (revision 257576)
+++ trunk/src/base/files/file.cc (working copy)
@@ -40,9 +40,6 @@
error_details_(FILE_OK),
created_(false),
async_(false) {
-#if defined(OS_POSIX)
- DCHECK_GE(platform_file, -1);
-#endif
}
File::File(RValue other)
@@ -53,6 +50,7 @@
}
File::~File() {
+ Close();
}
File& File::operator=(RValue other) {
« no previous file with comments | « trunk/src/base/files/file.h ('k') | trunk/src/base/files/file_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698