Issue 20258: * Issue 227 Fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20258: * Issue 227 Fix. (Closed)

Created:
11 years, 10 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Visibility:
Public.

Description

Issue 227 Fixed. Properly handles non-ASCII characters in quick-check on ASCII strings.

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -35 lines)			Patch
	M	src/jsregexp.cc	View		3 chunks	+48 lines, -35 lines	1 comment	Download
	A	test/mjsunit/regress/regress-227.js	View		1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

11 years, 10 months ago (2009-02-11 11:46:54 UTC) #2

Lgtm

http://codereview.chromium.org/20258/diff/1/2
File src/jsregexp.cc (right):

http://codereview.chromium.org/20258/diff/1/2#newcode2675
Line 2675: } else {
This code is disgustingly complicated.  Your code is not to blame but this code
should have been rejected in an earlier code review for having too many special
cases.

Expand Messages | Collapse Messages