Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThread.cpp

Issue 2025783002: Worker: Introduce an observation mechanism for WorkerThread termination (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@delayed_task
Patch Set: remake and add tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerThread.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerThread.cpp b/third_party/WebKit/Source/core/workers/WorkerThread.cpp
index 62c4fd888ac86f03869271c109be5607ccb159c8..82a3775be7c6f496840bd417f9166feb94840015 100644
--- a/third_party/WebKit/Source/core/workers/WorkerThread.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerThread.cpp
@@ -147,6 +147,24 @@ static HashSet<WorkerThread*>& workerThreads()
return threads;
}
+WorkerThreadContext::WorkerThreadContext()
+{
+ DCHECK(isMainThread());
+}
+
+WorkerThreadContext::~WorkerThreadContext()
+{
+ DCHECK(isMainThread());
+}
+
+void WorkerThreadContext::notifyContextDestroyed()
+{
+ DCHECK(isMainThread());
+ DCHECK(!m_wasContextDestroyed);
+ m_wasContextDestroyed = true;
+ LifecycleNotifier::notifyContextDestroyed();
+}
+
WorkerThread::~WorkerThread()
{
DCHECK(isMainThread());
@@ -292,7 +310,9 @@ WorkerThread::WorkerThread(PassRefPtr<WorkerLoaderProxy> workerLoaderProxy, Work
, m_shutdownEvent(adoptPtr(new WaitableEvent(
WaitableEvent::ResetPolicy::Manual,
WaitableEvent::InitialState::NonSignaled)))
+ , m_workerThreadContext(new WorkerThreadContext)
{
+ DCHECK(isMainThread());
MutexLocker lock(threadSetMutex());
workerThreads().add(this);
}
@@ -339,6 +359,8 @@ void WorkerThread::terminateInternal(TerminationMode mode)
if (m_terminationEvent)
m_terminationEvent->signal();
+ m_workerThreadContext->notifyContextDestroyed();
+
// If the worker thread was never initialized, don't start another
// shutdown, but still wait for the thread to signal when shutdown has
// completed on initializeOnWorkerThread().

Powered by Google App Engine
This is Rietveld 408576698