Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 2025773002: Remove node count checks from fast/dom/gc-dom-tree-lifetime.html (Closed)

Created:
4 years, 8 months ago by kouhei (in TOK)
Modified:
4 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove node count checks from fast/dom/gc-dom-tree-lifetime.html Before this CL, the test result depended on synchronous gc() call which was non-determistic after Oilpan. This CL removes the node count check to make the test runs deterministic. This change is safe, as the leak checks are now ensured by Blink Leak Detector, which supports Oilpan. BUG=606649 Committed: https://crrev.com/4584158cf0a8f5370832cb775aae08dd99560a09 Cr-Commit-Position: refs/heads/master@{#396774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/gc-dom-tree-lifetime.html View 1 chunk +1 line, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/gc-dom-tree-lifetime-expected.txt View 6 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kouhei (in TOK)
4 years, 8 months ago (2016-05-31 02:19:29 UTC) #2
kouhei (in TOK)
On 2016/05/31 02:19:29, kouhei (catching up) wrote: plz hit cq if lg
4 years, 8 months ago (2016-05-31 02:19:45 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-05-31 02:20:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025773002/1
4 years, 8 months ago (2016-05-31 02:20:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-05-31 03:21:25 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-05-31 03:23:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4584158cf0a8f5370832cb775aae08dd99560a09
Cr-Commit-Position: refs/heads/master@{#396774}

Powered by Google App Engine
This is Rietveld 408576698