Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(93)

Issue 2025753002: Move chooser_content_view from mac_sources to cocoa_sources (Closed)

Created:
4 years, 3 months ago by tapted
Modified:
4 years, 3 months ago
Reviewers:
juncai
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move chooser_content_view from mac_sources to cocoa_sources Fixes a MacViewsBrowser link error after r396494, starting at http://go/macviewsbuilder/builds/10865, like Undefined symbols for architecture x86_64: "_OBJC_CLASS_$_ConstrainedWindowButton", referenced from: objc-class-ref in libbrowser_ui.a(browser_ui.chooser_content_view.o) chooser_content_view is the Cocoa UI. MacViewsBrowser gets its UI for this from from chooser_bubble_ui_view.* BUG=425229, 612942 TBR=juncai@chromium.org Committed: https://crrev.com/6abb2c8a94305e390838712dd71f9c80df4ca1e7 Cr-Commit-Position: refs/heads/master@{#396771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tapted
4 years, 3 months ago (2016-05-31 02:42:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025753002/1
4 years, 3 months ago (2016-05-31 02:42:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-05-31 02:46:18 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-05-31 02:47:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6abb2c8a94305e390838712dd71f9c80df4ca1e7
Cr-Commit-Position: refs/heads/master@{#396771}

Powered by Google App Engine
This is Rietveld 408576698