Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2025743002: Get rid of redundant Range object usage in InputMethodController (Closed)

Created:
4 years, 6 months ago by yosin_UTC9
Modified:
4 years, 6 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of redundant Range object usage in InputMethodController This patch gets rid of redundant |Range| object usage in |InputMethodController| by replacing it with |EphemeralRange|, since usage of |Range| object is just a parameter for |FrameSelection::setSelectedRaneg()|, to reduce number of objects in Oilpan heap. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/539a4c003a9a89c1419cb3c11932e911ce43a230 Cr-Commit-Position: refs/heads/master@{#396770}

Patch Set 1 : 2016-05-31T10:08:27 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
yosin_UTC9
PTAL
4 years, 6 months ago (2016-05-31 01:40:47 UTC) #3
yoichio
lgtm
4 years, 6 months ago (2016-05-31 01:51:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025743002/1
4 years, 6 months ago (2016-05-31 01:54:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 02:44:48 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 02:47:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/539a4c003a9a89c1419cb3c11932e911ce43a230
Cr-Commit-Position: refs/heads/master@{#396770}

Powered by Google App Engine
This is Rietveld 408576698