Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: ui/events/keycodes/platform_key_map_win_unittest.cc

Issue 2025733002: [DomKey] Use VK->DomKey mapping for non-printable keys (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Wez's review 2 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/keycodes/platform_key_map_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/keycodes/platform_key_map_win_unittest.cc
diff --git a/ui/events/keycodes/platform_key_map_win_unittest.cc b/ui/events/keycodes/platform_key_map_win_unittest.cc
index 44cbd58671528618ed25d93cee00ba9f4dfe800f..1a3fb352f79868bc4ea3cc970792f6425e68cec4 100644
--- a/ui/events/keycodes/platform_key_map_win_unittest.cc
+++ b/ui/events/keycodes/platform_key_map_win_unittest.cc
@@ -5,11 +5,13 @@
#include "ui/events/keycodes/platform_key_map_win.h"
#include "base/macros.h"
+#include "base/strings/string16.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/events/event_constants.h"
#include "ui/events/keycodes/dom/dom_code.h"
#include "ui/events/keycodes/dom/dom_key.h"
#include "ui/events/keycodes/dom/keycode_converter.h"
+#include "ui/events/keycodes/dom_us_layout_data.h"
namespace ui {
@@ -247,4 +249,42 @@ TEST_F(PlatformKeyMapTest, NumPad) {
}
}
+TEST_F(PlatformKeyMapTest, NonPrintableKey) {
+ HKL layout = ::LoadKeyboardLayout(LAYOUT_US, 0);
+ PlatformKeyMap keymap(layout);
+
+ for (const auto& test_case : kNonPrintableCodeMap) {
+ // Not available on |LAYOUT_US|.
+ if (test_case.dom_code == DomCode::PAUSE ||
+ test_case.dom_code == DomCode::LANG2 ||
+ test_case.dom_code == DomCode::NON_CONVERT)
+ continue;
+
+ int scan_code =
+ ui::KeycodeConverter::DomCodeToNativeKeycode(test_case.dom_code);
+ // TODO(chongz): Some |scan_code| should map to different |key_code| based
+ // on modifiers.
+ KeyboardCode key_code = static_cast<KeyboardCode>(
+ ::MapVirtualKeyEx(scan_code, MAPVK_VSC_TO_VK, layout));
+
+ if (key_code == VKEY_UNKNOWN)
+ continue;
+
+ EXPECT_EQ(test_case.dom_key,
+ DomKeyFromNativeImpl(keymap, DomCode::NONE, key_code, EF_NONE))
+ << key_code << ", " << scan_code;
+ EXPECT_EQ(test_case.dom_key, DomKeyFromNativeImpl(keymap, DomCode::NONE,
+ key_code, EF_ALTGR_DOWN))
+ << key_code << ", " << scan_code;
+ EXPECT_EQ(
+ test_case.dom_key,
+ DomKeyFromNativeImpl(keymap, DomCode::NONE, key_code, EF_CONTROL_DOWN))
+ << key_code << ", " << scan_code;
+ EXPECT_EQ(test_case.dom_key,
+ DomKeyFromNativeImpl(keymap, DomCode::NONE, key_code,
+ EF_ALTGR_DOWN | EF_CONTROL_DOWN))
+ << key_code << ", " << scan_code;
+ }
+}
+
} // namespace ui
« no previous file with comments | « ui/events/keycodes/platform_key_map_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698