[DomKey] Use VK->DomKey mapping for non-printable keys

ui/events/keycodes/platform_key_map_win_unittest.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/keycodes/platform_key_map_win.h"
 
 #include "base/macros.h"
+#include "base/strings/string16.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/events/event_constants.h"
 #include "ui/events/keycodes/dom/dom_code.h"
 #include "ui/events/keycodes/dom/dom_key.h"
 #include "ui/events/keycodes/dom/keycode_converter.h"
+#include "ui/events/keycodes/dom_us_layout_data.h"
 
 namespace ui {
 
 namespace {
 
 const wchar_t* LAYOUT_US = L"00000409";
 const wchar_t* LAYOUT_FR = L"0000040c";
 
 struct TestKey {
   // Have to use KeyboardCode instead of DomCode because we don't know the
@@ skipping 217 matching lines @@
     EXPECT_EQ(test_case.key,
               DomKeyFromNativeImpl(keymap, dom_code, key_code, EF_CONTROL_DOWN))
         << key_code;
     EXPECT_EQ(test_case.key,
               DomKeyFromNativeImpl(keymap, dom_code, key_code,
                                    EF_ALTGR_DOWN | EF_CONTROL_DOWN))
         << key_code;
   }
 }
 
+TEST_F(PlatformKeyMapTest, NonPrintableKey) {
+  HKL layout = ::LoadKeyboardLayout(LAYOUT_US, 0);
+  PlatformKeyMap keymap(layout);
+
+  for (const auto& test_case : kNonPrintableCodeMap) {
+    // Not available on |LAYOUT_US|.
+    if (test_case.dom_code == DomCode::PAUSE ||
+        test_case.dom_code == DomCode::LANG2 ||
+        test_case.dom_code == DomCode::NON_CONVERT)
+      continue;
+
+    int scan_code =
+        ui::KeycodeConverter::DomCodeToNativeKeycode(test_case.dom_code);
+    KeyboardCode key_code = static_cast<KeyboardCode>(
+        ::MapVirtualKeyEx(scan_code, MAPVK_VSC_TO_VK, layout));
+
+    if (!key_code)

[Wez, 2016/06/03 00:00:52]

nit: I'd explicitly test against VKEY_UNKNOWN here, since |key_code| is an enum.

+      continue;
+
+    EXPECT_EQ(test_case.dom_key,
+              DomKeyFromNativeImpl(keymap, DomCode::NONE, key_code, EF_NONE))
+        << key_code << ", " << scan_code;
+    EXPECT_EQ(test_case.dom_key, DomKeyFromNativeImpl(keymap, DomCode::NONE,
+                                                      key_code, EF_ALTGR_DOWN))
+        << key_code << ", " << scan_code;
+    EXPECT_EQ(
+        test_case.dom_key,
+        DomKeyFromNativeImpl(keymap, DomCode::NONE, key_code, EF_CONTROL_DOWN))
+        << key_code << ", " << scan_code;
+    EXPECT_EQ(test_case.dom_key,
+              DomKeyFromNativeImpl(keymap, DomCode::NONE, key_code,
+                                   EF_ALTGR_DOWN | EF_CONTROL_DOWN))
+        << key_code << ", " << scan_code;
+  }
+}
+
 }  // namespace ui