xfa_fm2jscontext formatting and cleanup - pt I

xfa/fxfa/fm2js/xfa_fm2jsapi.cpp

Index: xfa/fxfa/fm2js/xfa_fm2jsapi.cpp
diff --git a/xfa/fxfa/fm2js/xfa_fm2jsapi.cpp b/xfa/fxfa/fm2js/xfa_fm2jsapi.cpp
index 00c4edf447945a91dc44994cbd0a20c7527eab30..826739a9e759f0395f186ac3ec79dacb74ec9691 100644
--- a/xfa/fxfa/fm2js/xfa_fm2jsapi.cpp
+++ b/xfa/fxfa/fm2js/xfa_fm2jsapi.cpp
@@ -39,17 +39,11 @@ int32_t XFA_FM2JS_Translate(const CFX_WideStringC& wsFormcalc,
   return 0;
 }
 
-XFA_HFM2JSCONTEXT XFA_FM2JS_ContextCreate() {
-  return reinterpret_cast<XFA_HFM2JSCONTEXT>(new CXFA_FM2JSContext);
-}
-
-void XFA_FM2JS_ContextInitialize(XFA_HFM2JSCONTEXT hFM2JSContext,
-                                 v8::Isolate* pScriptIsolate,
-                                 CFXJSE_Context* pScriptContext,
-                                 CXFA_Document* pDocument) {
-  CXFA_FM2JSContext* pContext =
-      reinterpret_cast<CXFA_FM2JSContext*>(hFM2JSContext);
-  pContext->Initialize(pScriptIsolate, pScriptContext, pDocument);
+XFA_HFM2JSCONTEXT XFA_FM2JS_ContextCreate(v8::Isolate* pScriptIsolate,

[Tom Sepez, 2016/05/31 16:33:17]

can we lose the XFA_HFM2JSCONTEXT opaque type and just make this
CXFA_FM2JSContext::Create() ?

Ditto with the rest of these -- we have a layer of abstraction here that doesn't
serve anyone.

[dsinclair, 2016/05/31 18:42:40]

Will do as a followup

+                                          CFXJSE_Context* pScriptContext,
+                                          CXFA_Document* pDocument) {
+  return reinterpret_cast<XFA_HFM2JSCONTEXT>(
+      new CXFA_FM2JSContext(pScriptIsolate, pScriptContext, pDocument));
 }
 
 void XFA_FM2JS_GlobalPropertyGetter(XFA_HFM2JSCONTEXT hFM2JSContext,

[Tom Sepez, 2016/05/31 16:33:17]

This ought to be static method CXFA_FM2JSContext::Getter(void* or whaterver).

[dsinclair, 2016/05/31 18:42:40]

This will just go a way once the opaque type is removed and we can change the
callers to ->GlobalPropertyGetter.