xfa_fm2jscontext formatting and cleanup - pt I

xfa/fxfa/fm2js/xfa_fm2jscontext.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef XFA_FXFA_FM2JS_XFA_FM2JSCONTEXT_H_
 #define XFA_FXFA_FM2JS_XFA_FM2JSCONTEXT_H_
 
 #include "xfa/fxfa/parser/xfa_script.h"
@@ skipping 409 matching lines @@
                                  CFXJSE_Value* pParentValue,
                                  CFXJSE_Value**& resultValues,
                                  int32_t& iSize,
                                  FX_BOOL& bAttribute);
 
   static std::unique_ptr<CFXJSE_Value> GetSimpleValue(CFXJSE_Value* pThis,
                                                       CFXJSE_Arguments& args,
                                                       uint32_t index);
   static FX_BOOL ValueIsNull(CFXJSE_Value* pThis, CFXJSE_Value* pValue);
   static int32_t ValueToInteger(CFXJSE_Value* pThis, CFXJSE_Value* pValue);
-  static FX_DOUBLE StringToDouble(const CFX_ByteStringC& szStringVal);
   static FX_FLOAT ValueToFloat(CFXJSE_Value* pThis, CFXJSE_Value* pValue);
   static FX_DOUBLE ValueToDouble(CFXJSE_Value* pThis, CFXJSE_Value* pValue);
   static void ValueToUTF8String(CFXJSE_Value* pValue,
                                 CFX_ByteString& outputValue);
 
-  CXFA_FM2JSContext();
+  CXFA_FM2JSContext(v8::Isolate* pScriptIsolate,
+                    CFXJSE_Context* pScriptContext,
+                    CXFA_Document* pDoc);
   ~CXFA_FM2JSContext();
 
-  void Initialize(v8::Isolate* pScriptIsolate,
-                  CFXJSE_Context* pScriptContext,
-                  CXFA_Document* pDoc);
   void GlobalPropertyGetter(CFXJSE_Value* pValue);
 
+ private:
   v8::Isolate* GetScriptRuntime() const { return m_pIsolate; }
   CXFA_Document* GetDocument() const { return m_pDocument; }
   void ThrowScriptErrorMessage(int32_t iStringID, ...);
 
- private:
   v8::Isolate* m_pIsolate;
   CFXJSE_Class* m_pFMClass;
   std::unique_ptr<CFXJSE_Value> m_pValue;
   CXFA_Document* m_pDocument;

[Tom Sepez, 2016/05/31 16:33:17]

probaby CXFA_Document* const m_pDocument, as I don't see these hopping between
documents during their lifespan.

[dsinclair, 2016/05/31 18:42:40]

Done.

 };
 
 #endif  // XFA_FXFA_FM2JS_XFA_FM2JSCONTEXT_H_