Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2025713003:
SkEncodedInfo: simplify (Closed)
|
Created:
4 years, 6 months ago by hal.canary Modified:
4 years, 6 months ago Reviewers:
msarett CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionSkEncodedInfo: simplify
No public API change.
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2025713003
Committed: https://skia.googlesource.com/skia/+/a9ef92a5ede83f27e61297e87751ec657a564fef
Patch Set 1 #
Messages
Total messages: 22 (12 generated)
Description was changed from ========== SkEncodedInfo: simplify . ========== to ========== SkEncodedInfo: simplify . GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2025713003 ==========
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025713003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
halcanary@google.com changed reviewers: + msarett@google.com
ptal
lgtm
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025713003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Description was changed from ========== SkEncodedInfo: simplify . GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2025713003 ========== to ========== SkEncodedInfo: simplify No public API change. TBR=reed@ GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2025713003 ==========
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025713003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Description was changed from ========== SkEncodedInfo: simplify No public API change. TBR=reed@ GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2025713003 ========== to ========== SkEncodedInfo: simplify No public API change. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2025713003 ==========
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025713003/1
Message was sent while issue was closed.
Description was changed from ========== SkEncodedInfo: simplify No public API change. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2025713003 ========== to ========== SkEncodedInfo: simplify No public API change. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2025713003 Committed: https://skia.googlesource.com/skia/+/a9ef92a5ede83f27e61297e87751ec657a564fef ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/a9ef92a5ede83f27e61297e87751ec657a564fef |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
