Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(110)

Issue 2025693002: Implement SetWrapperReferenceTo idl attribute within traceWrappers for MIDIInput and MIDIOutput (Closed)

Created:
4 years, 3 months ago by Marcel Hlopko
Modified:
4 years, 3 months ago
CC:
blink-reviews, chromium-reviews, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement SetWrapperReferenceTo idl attribute within traceWrappers for MIDIInput and MIDIOutput Follow status of tracing SetWrapperReferenceTo here: https://docs.google.com/a/google.com/spreadsheets/d/1S-LZ6rovnfg8-yw3a74KEC7CvUGVDjp994AXYj7c9wg/edit?usp=sharing LOG=no BUG=468240 Committed: https://crrev.com/2c27202a60625acf315f491ee1cf1e0e67463996 Cr-Commit-Position: refs/heads/master@{#396794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/webmidi/MIDIPort.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIPort.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Marcel Hlopko
Ptal.
4 years, 3 months ago (2016-05-30 15:47:48 UTC) #2
haraken
LGTM
4 years, 3 months ago (2016-05-30 15:48:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025693002/1
4 years, 3 months ago (2016-05-30 15:49:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/230208)
4 years, 3 months ago (2016-05-30 20:38:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025693002/1
4 years, 3 months ago (2016-05-31 04:43:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-05-31 06:43:16 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-05-31 06:45:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c27202a60625acf315f491ee1cf1e0e67463996
Cr-Commit-Position: refs/heads/master@{#396794}

Powered by Google App Engine
This is Rietveld 408576698