content/browser/frame_host/navigation_handle_impl.cc - Issue 2025683003: First experimental implementation of the Clear-Site-Data header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2025683003: First experimental implementation of the Clear-Site-Data header (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browsing_data/clear_site_data_throttle.cc ('K') | « content/browser/browsing_data/clear_site_data_throttle_unittest.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_handle_impl.cc

diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc

index 7857c9631ee6d4119acecc79dd5efa5bf55e1809..4fb1f971c1fe212231d691b7f3af7e87ce25920e 100644

--- a/content/browser/frame_host/navigation_handle_impl.cc

+++ b/content/browser/frame_host/navigation_handle_impl.cc

@@ -7,6 +7,7 @@

#include <utility>

#include "base/logging.h"

+#include "content/browser/browsing_data/clear_site_data_throttle.h"

#include "content/browser/devtools/render_frame_devtools_agent_host.h"

#include "content/browser/frame_host/frame_tree_node.h"

#include "content/browser/frame_host/navigator.h"

@@ -556,7 +557,12 @@ void NavigationHandleImpl::RegisterNavigationThrottles() {

std::unique_ptr<NavigationThrottle> devtools_throttle =

RenderFrameDevToolsAgentHost::CreateThrottleForNavigation(this);

if (devtools_throttle)

- throttles_to_register.push_back(devtools_throttle.release());

+ throttles_to_register.push_back(std::move(devtools_throttle));

+ std::unique_ptr<NavigationThrottle> clear_site_data_throttle =

+ ClearSiteDataThrottle::CreateThrottleForNavigation(this);

+ if (clear_site_data_throttle)

+ throttles_to_register.push_back(std::move(clear_site_data_throttle));

if (throttles_to_register.size() > 0) {

throttles_.insert(throttles_.begin(), throttles_to_register.begin(),