chrome/browser/browsing_data/registrable_domain_filter_builder.cc - Issue 2025683003: First experimental implementation of the Clear-Site-Data header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/registrable_domain_filter_builder.cc

Issue 2025683003: First experimental implementation of the Clear-Site-Data header (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/registrable_domain_filter_builder.h ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | content/browser/browsing_data/clear_site_data_throttle_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/registrable_domain_filter_builder.cc

diff --git a/chrome/browser/browsing_data/registrable_domain_filter_builder.cc b/chrome/browser/browsing_data/registrable_domain_filter_builder.cc

index a0604834ea0e8dc27d490b4505b30f0262024fce..139b046f7983f020dc8bceddcb5d071c3f61baf0 100644

--- a/chrome/browser/browsing_data/registrable_domain_filter_builder.cc

+++ b/chrome/browser/browsing_data/registrable_domain_filter_builder.cc

@@ -107,6 +107,11 @@ RegistrableDomainFilterBuilder::BuildChannelIDFilter() const {

base::Owned(domains_and_ips), mode());

}

+bool RegistrableDomainFilterBuilder::operator==(

+ const RegistrableDomainFilterBuilder& other) const {

+ return domain_list_ == other.domain_list_ && mode() == other.mode();

Mike West 2016/07/18 08:48:18 To shrink this CL, and give you pieces to land rig

msramek 2016/07/18 10:02:04 Extracted to https://codereview.chromium.org/21615

bool RegistrableDomainFilterBuilder::IsEmpty() const {

return domain_list_.empty();

}