Chromium Code Reviews| Index: content/browser/browsing_data/clear_site_data_throttle_unittest.cc |
| diff --git a/content/browser/browsing_data/clear_site_data_throttle_unittest.cc b/content/browser/browsing_data/clear_site_data_throttle_unittest.cc |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..fda0dd712aa7cdd7c2d90bc832f1da1c74ecb165 |
| --- /dev/null |
| +++ b/content/browser/browsing_data/clear_site_data_throttle_unittest.cc |
| @@ -0,0 +1,114 @@ |
| +// Copyright 2016 The Chromium Authors. All rights reserved. |
| +// Use of this source code is governed by a BSD-style license that can be |
| +// found in the LICENSE file. |
| + |
| +#include "content/browser/browsing_data/clear_site_data_throttle.h" |
| + |
| +#include <memory> |
| + |
| +#include "testing/gmock/include/gmock/gmock.h" |
| +#include "testing/gtest/include/gtest/gtest.h" |
| + |
| +namespace content { |
| + |
| +class ClearSiteDataThrottleTest : public testing::Test { |
| + public: |
| + void SetUp() override { |
| + throttle_ = ClearSiteDataThrottle::CreateThrottleFor(nullptr); |
| + } |
| + |
| + ClearSiteDataThrottle* GetThrottle() { |
| + return static_cast<ClearSiteDataThrottle*>(throttle_.get()); |
| + } |
| + |
| + private: |
| + std::unique_ptr<NavigationThrottle> throttle_; |
| +}; |
| + |
| +TEST_F(ClearSiteDataThrottleTest, ParseHeader) { |
| + struct TestCase { |
| + const char* header; |
| + bool cookies; |
| + bool storage; |
| + bool cache; |
| + } test_cases[] = { |
| + // One data type. |
| + {"{ \"types\": [\"cookies\"] }", true, false, false}, |
| + {"{ \"types\": [\"storage\"] }", false, true, false}, |
| + {"{ \"types\": [\"cache\"] }", false, false, true}, |
| + |
| + // Two data types. |
| + {"{ \"types\": [\"cookies\", \"cache\"] }", true, false, true}, |
|
Mike West
2016/06/20 07:57:38
You might as well do all of the options.
msramek
2016/07/15 16:47:39
Done.
|
| + |
| + // Three data types. |
| + {"{ \"types\": [\"storage\", \"cache\", \"cookies\"] }", true, true, true}, |
|
Mike West
2016/06/20 07:57:38
Might as well add a check that the order doesn't m
msramek
2016/07/15 16:47:39
Done.
|
| + |
| + // Different formatting. |
| + {" { \"types\": [\"cookies\" ]}", true, false, false}, |
| + |
| + // Other entries in the dictionary. |
| + {"{ \"types\": [\"storage\"], \"other_params\": {} }", false, true, false}, |
| + |
| + // Unknown types are ignored, but we still proceed with the deletion for |
| + // those that we recognize. |
| + {"{ \"types\": [\"cache\", \"foo\"] }", false, false, true}, |
| + }; |
| + |
| + for (const TestCase& test_case : test_cases) { |
| + SCOPED_TRACE(test_case.header); |
| + |
| + bool actual_cookies; |
| + bool actual_storage; |
| + bool actual_cache; |
| + |
| + std::vector<ClearSiteDataThrottle::ConsoleMessage> messages; |
| + |
| + EXPECT_TRUE(GetThrottle()->ParseHeader( |
| + test_case.header, |
| + &actual_cookies, &actual_storage, &actual_cache, &messages)); |
| + |
| + EXPECT_EQ(test_case.cookies, actual_cookies); |
| + EXPECT_EQ(test_case.storage, actual_storage); |
| + EXPECT_EQ(test_case.cache, actual_cache); |
| + } |
| +} |
| + |
| +TEST_F(ClearSiteDataThrottleTest, InvalidHeader) { |
| + struct TestCase { |
| + const char* header; |
| + const char* console_message; |
| + } test_cases[] = { |
| + { "", " is not a valid JSON.\n" }, |
| + { "\"unclosed quote", "\"unclosed quote is not a valid JSON.\n" }, |
| + { "\"some text\"", "\"some text\" is not a dictionary.\n" }, |
| + { "{ \"field\" : {} }", |
| + "No \'types\' field present in { \"field\" : {} }.\n" }, |
| + { "{ \"types\" : [ \"passwords\" ] }", |
| + "Invalid type: 'passwords'.\n" |
| + "No valid types specified in { \"types\" : [ \"passwords\" ] }.\n" }, |
| + }; |
| + |
| + for (const TestCase& test_case : test_cases) { |
| + SCOPED_TRACE(test_case.header); |
| + |
| + bool actual_cookies; |
| + bool actual_storage; |
| + bool actual_cache; |
| + |
| + std::vector<ClearSiteDataThrottle::ConsoleMessage> messages; |
| + |
| + EXPECT_FALSE(GetThrottle()->ParseHeader( |
| + test_case.header, |
| + &actual_cookies, &actual_storage, &actual_cache, &messages)); |
| + |
| + std::string multiline_message; |
| + for (const ClearSiteDataThrottle::ConsoleMessage& message : messages) { |
| + EXPECT_EQ(CONSOLE_MESSAGE_LEVEL_ERROR, message.level); |
| + multiline_message += message.text + "\n"; |
| + } |
| + |
| + EXPECT_EQ(test_case.console_message, multiline_message); |
| + } |
| +} |
| + |
| +} // namespace content |