First experimental implementation of the Clear-Site-Data header

content/public/browser/content_browser_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 
 #include <stddef.h>
 
 #include <map>
@@ skipping 532 matching lines @@
   // Notifies that BrowserURLHandler has been created, so that the embedder can
   // optionally add their own handlers.
   virtual void BrowserURLHandlerCreated(BrowserURLHandler* handler) {}
 
   // Clears browser cache.
   virtual void ClearCache(RenderFrameHost* rfh) {}
 
   // Clears browser cookies.
   virtual void ClearCookies(RenderFrameHost* rfh) {}
 
+  // Clears |browser_context|'s data stored for the given |origin|.
+  // The datatypes to be removed are specified by |remove_cookies|,
+  // |remove_storage|, and |remove_cache|. Note that cookies will be removed
+  // for the entire eTLD+1 of |origin|.

[nasko, 2016/07/28 17:30:31]

Why would cookies and other types of data differ?

[msramek, 2016/08/01 16:03:19]

The proposal is to delete data for an origin as a security boundary. However,
when we started building the infrastructure to this change, it was pointed out
that "it will break the web". Websites generally use cookies from different
origins (e.g. mail.google.com from accounts.google.com); such partial deletion
would lead to unexpected behavior (inconsistent state), and it would also not
achieve the goal of clearing all places where the website could possibly store
data.

It's possible that we'll eventually decide to delete everything per origin
anyway, or that we'll switch to eTLD+1 for consistency. But for V1, we just want
to use what we have so that we can start experimenting in the real world.

+  virtual void ClearSiteData(
+      content::BrowserContext* browser_context, const url::Origin& origin,

[nasko, 2016/07/28 17:30:31]

style: Each parameter goes on a new line. Ideally, just run "git cl format" to
have automated tools take care of the formatting.

[msramek, 2016/08/01 16:03:19]

Done, also ran git cl format. (Some parts of this CL are definitely better
formatted now, but sometimes git cl format produces less readable results).

[nasko, 2016/08/03 20:53:13]

The main goal of git cl format is to remove any discussions on what looks more
or less readable, so please run it on all CLs. You remove a layer of cognitive
load from reviewers and lets them spend more mental energy on the things that
matter.

+      bool remove_cookies, bool remove_storage, bool remove_cache) {}
+
   // Returns the default download directory.
   // This can be called on any thread.
   virtual base::FilePath GetDefaultDownloadDirectory();
 
   // Returns the default filename used in downloads when we have no idea what
   // else we should do with the file.
   virtual std::string GetDefaultDownloadName();
 
   // Returns the path to the browser shader disk cache root.
   virtual base::FilePath GetShaderDiskCacheDirectory();
@@ skipping 212 matching lines @@
   // Allows an embedder to provide its own ExternalVideoSurfaceContainer
   // implementation.  Return nullptr to disable external surface video.
   virtual ExternalVideoSurfaceContainer*
   OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents);
 #endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_