Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 2025643002: Fixing HtmlAudioElementCapturerSource::OnAudioBus() to accept delay frames intead of milliseconds. (Closed)

Created:
4 years, 6 months ago by o1ka
Modified:
4 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, miu+watch_chromium.org, DaleCurtis, mcasas, vanellope-cl_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing HtmlAudioElementCapturerSource::OnAudioBus() to accept delay frames intead of milliseconds. (frames are passed here https://cs-staging.chromium.org/chromium/src/media/blink/webaudiosourceprovider_impl.cc?sq=package:chromium&dr=C&rcl=1464592669&l=276) BUG=615783 Committed: https://crrev.com/09f80bc860fedce41702537cdd742ae03370bfdf Cr-Commit-Position: refs/heads/master@{#396744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M content/renderer/media/html_audio_element_capturer_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/html_audio_element_capturer_source.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
o1ka
tommi@, could you PTAL?
4 years, 6 months ago (2016-05-30 12:06:51 UTC) #2
tommi (sloooow) - chröme
lgtm! nice find - I guess we'll need to merge this to 52.
4 years, 6 months ago (2016-05-30 12:09:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025643002/1
4 years, 6 months ago (2016-05-30 12:10:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/78642)
4 years, 6 months ago (2016-05-30 13:48:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025643002/1
4 years, 6 months ago (2016-05-30 15:56:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 17:41:09 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/09f80bc860fedce41702537cdd742ae03370bfdf Cr-Commit-Position: refs/heads/master@{#396744}
4 years, 6 months ago (2016-05-30 17:42:40 UTC) #12
chcunningham
Sorry I missed this one! Thanks a ton
4 years, 6 months ago (2016-05-31 16:21:49 UTC) #13
miu
On 2016/05/31 16:21:49, chcunningham wrote: > Sorry I missed this one! Thanks a ton I ...
4 years, 6 months ago (2016-05-31 19:59:27 UTC) #14
o1ka
4 years, 6 months ago (2016-06-01 11:31:37 UTC) #15
Message was sent while issue was closed.
On 2016/05/31 19:59:27, miu wrote:
> On 2016/05/31 16:21:49, chcunningham wrote:
> > Sorry I missed this one! Thanks a ton
> 
> I think this was new code being committed at the same time and the frame_delay
> change.

Yes, combined with misleading naming the new code relied on
(https://bugs.chromium.org/p/chromium/issues/detail?id=604313).
But we caught it early this time :)

Powered by Google App Engine
This is Rietveld 408576698