Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2025623007: Add declarations needed to build cast_shell_media with mojo. (Closed)

Created:
4 years, 6 months ago by dougsteed
Modified:
4 years, 6 months ago
Reviewers:
alokp
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, lcwu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, halliwell+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add declarations needed to build cast_shell_media with mojo. BUG= Committed: https://crrev.com/dbe6ed5895abba6aa038717930a30cddff66f7a1 Cr-Commit-Position: refs/heads/master@{#397227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chromecast/browser/media/cast_mojo_media_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
alokp
lgtm
4 years, 6 months ago (2016-06-01 17:34:15 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025623007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025623007/1
4 years, 6 months ago (2016-06-01 17:59:36 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 19:35:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025623007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025623007/1
4 years, 6 months ago (2016-06-01 20:14:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 20:20:02 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 20:22:09 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dbe6ed5895abba6aa038717930a30cddff66f7a1
Cr-Commit-Position: refs/heads/master@{#397227}

Powered by Google App Engine
This is Rietveld 408576698