Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(45)

Issue 2025613002: Reland: Show message center on lock screen (Closed)

Created:
4 years, 3 months ago by yoshiki
Modified:
4 years, 3 months ago
CC:
chromium-reviews, Peter Beverloo, kalyank, mlamouri+watch-notifications_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Show message center on lock screen The original CL (crrev.com/396402) was comitted but reverted (crrev.com/396495) due to MSAN failure (forgetting free the instance). This patch relands it with changing it with unique_ptr. BUG=615443 TEST=MSAN bot passes TBR=dewittj@chromium.org, skuhne@chromium.org This patch does: - Show the message center button on tray on the lock screen - Show the message to encourage user to log in when user opens message center on lock screen - Add SetLockedState(bool) and IsLockedState() method into MessageCenter class. - Don't make notifications read when opening the message center on lock screen - Add tests And this patch also fixes the bug that this makes blocked notifications read wrongly. BUG=599891 TEST=manually tested Committed: https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50 Cr-Commit-Position: refs/heads/master@{#396402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -59 lines) Patch
M ash/system/web_notification/web_notification_tray.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M ui/message_center/fake_message_center.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/message_center/fake_message_center.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/message_center/message_center.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/message_center/message_center_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ui/message_center/message_center_impl.cc View 8 chunks +27 lines, -15 lines 0 comments Download
M ui/message_center/message_center_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/message_center/notification_list.h View 3 chunks +6 lines, -9 lines 0 comments Download
M ui/message_center/notification_list.cc View 4 chunks +8 lines, -14 lines 0 comments Download
M ui/message_center/notification_list_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M ui/message_center/views/message_center_view.h View 3 chunks +4 lines, -0 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 7 chunks +21 lines, -7 lines 0 comments Download
M ui/message_center/views/message_center_view_unittest.cc View 8 chunks +101 lines, -0 lines 0 comments Download
M ui/strings/ui_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025613002/1
4 years, 3 months ago (2016-05-31 02:48:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-05-31 04:58:29 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-05-31 04:59:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec
Cr-Commit-Position: refs/heads/master@{#396785}

Powered by Google App Engine
This is Rietveld 408576698