Show all system process in the task_manager.

chrome/browser/chromeos/arc/arc_process_service.h

 // Copyright 2016 The Chromium Authors. All rights reserved.

[Yusuke Sato, 2016/06/02 21:50:11]

Comment to the CL description:
I think you should file a bug on Chromium side (just like
https://bugs.chromium.org/p/chromium/issues/detail?id=616159 ) and use the bug#
in BUG=. Rietveld cannot update b/.

[Hsu-Cheng, 2016/06/29 10:33:57]

Done.

[Yusuke Sato, 2016/06/30 19:46:51]

Not yet done?

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_PROCESS_SERVICE_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_PROCESS_SERVICE_H_
 
 #include <map>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
+#include "base/process/process_iterator.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/threading/thread_checker.h"
 #include "chrome/browser/chromeos/arc/arc_process.h"
 #include "components/arc/arc_bridge_service.h"
 #include "components/arc/arc_service.h"
 
 namespace arc {
 
 // A single global entry to get a list of ARC processes.
 //
-// Call RequestProcessList() on the main UI thread to get a list of all ARC
-// processes. It returns vector<arc::ArcProcess>, which includes pid <-> nspid
-// mapping.
+// Call RequestAppProcessList() / RequestSystemProcessList on the main UI

[cylee1, 2016/06/02 20:58:45]

nit: RequestSystemProcessList()

[Hsu-Cheng, 2016/06/29 10:33:57]

Done.

+// thread to get a list of all ARC app / system processes. It returns
+// vector<arc::ArcProcess>, which includes pid <-> nspid mapping.
 // Example:
 //   void OnUpdateProcessList(const vector<arc::ArcProcess>&) {...}
 //
 //   arc::ArcProcessService* arc_process_service =
 //       arc::ArcProcessService::Get();
 //   if (!arc_process_service ||
-//       !arc_process_service->RequestProcessList(
+//       !arc_process_service->RequestAppProcessList(
 //           base::Bind(&OnUpdateProcessList)) {
 //     LOG(ERROR) << "ARC process instance not ready.";
 //   }
 class ArcProcessService : public ArcService,
                           public ArcBridgeService::Observer {
  public:
   using RequestProcessListCallback =
       base::Callback<void(const std::vector<ArcProcess>&)>;
 
   explicit ArcProcessService(ArcBridgeService* bridge_service);
   ~ArcProcessService() override;
 
   // Returns nullptr before the global instance is ready.
   static ArcProcessService* Get();
 
   // ArcBridgeService::Observer overrides.
   void OnProcessInstanceReady() override;
 
   // Returns true if ARC IPC is ready for process list request,
   // otherwise false.
-  bool RequestProcessList(RequestProcessListCallback callback);
+  bool RequestAppProcessList(RequestProcessListCallback callback);
+  bool RequestSystemProcessList(RequestProcessListCallback callback);

[cylee1, 2016/06/02 20:58:45]

Have you measured how much time does the function take ?
If it's costly you should leave a comment here to note it's a slow function.

Also please try to give "system process" a definition. It's not trivial from the
name.

[Hsu-Cheng, 2016/06/29 10:33:57]

I didn't test it with stress scenario. The time needed is about 5 ~ 30ms under
normal use depending on the system loading. I think this is costly and I will
add a note for it.

 
  private:
   void Reset();
 
+  void FetchAndReturnSystemProcessList(std::vector<ArcProcess>* ret_processes);
+
+  base::ProcessId GetArcInitProcessId(

[Yusuke Sato, 2016/06/02 21:50:11]

can be static

[Hsu-Cheng, 2016/06/29 10:33:57]

Done.

+      const base::ProcessIterator::ProcessEntries& entry_list);
+
   void OnReceiveProcessList(
       const RequestProcessListCallback& callback,
       mojo::Array<arc::mojom::RunningAppProcessInfoPtr> mojo_processes);
 
   void CallbackRelay(
       const RequestProcessListCallback& callback,
       const std::vector<ArcProcess>* ret_processes);
 
   void UpdateAndReturnProcessList(
       const std::vector<arc::mojom::RunningAppProcessInfoPtr>* raw_processes,
@@ skipping 18 matching lines @@
   // Always keep this the last member of this class to make sure it's the
   // first thing to be destructed.
   base::WeakPtrFactory<ArcProcessService> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcProcessService);
 };
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_PROCESS_SERVICE_H_