Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2025513002: Forward "testonly" variables in repack and repack_and_bundle template. (Closed)

Created:
4 years, 6 months ago by sdefresne
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Forward "testonly" variables in repack and repack_and_bundle template. It was suggested in previous CL http://crrev.com/2009803002 to forward that variable. This CL does just that and convert some other variables forwarding to use forward_variables_from instead of using an explicit test. BUG=459705, 567809 Committed: https://crrev.com/31d9821a3cd7d155c5f46de5bd2591599f9d9cc9 Cr-Commit-Position: refs/heads/master@{#396754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M tools/grit/repack.gni View 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look and send to CQ if lgty.
4 years, 6 months ago (2016-05-28 12:39:56 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-05-30 20:27:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025513002/1
4 years, 6 months ago (2016-05-30 20:28:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 22:01:48 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 22:04:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31d9821a3cd7d155c5f46de5bd2591599f9d9cc9
Cr-Commit-Position: refs/heads/master@{#396754}

Powered by Google App Engine
This is Rietveld 408576698