Revert of Expand WTF::StringView's API to be more like StringPiece.

Revert of Expand WTF::StringView's API to be more like StringPiece. (patchset #12 id:220001 of https://codereview.chromium.org/2007103003/ )

Reason for revert:
Many a heap-buffer-overflow ASan failures,

 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/24329

Original issue's description:
> Expand WTF::StringView's API to be more like StringPiece.
>
> StringView no longer owns the string passed into it, and can now wrap
> a raw ptr to some characters.
>
> This allows us to leverage the inline strlen optimization where the
> compiler will embed the length of literal strings into the binary. It
> also allows the deletion many overloaded methods that used to take
> an LChar*, UChar* or String and can now just take a StringView instead.
>
> For example the two constructors in TextRun are now a single one that
> takes a StringView. This needed to be done in this patch to avoid
> ambiguous constructors.
>
> Future patches will replace CSSParserString with StringView, and also
> vastly simplify the huge number of overloads on various methods. We'll
> also expand the API surface of StringView to include the many useful
> operations that StringPiece has.
>
> BUG=615174
>
> Committed: https://crrev.com/330deea56e27bc760fa52101040a51428bb7f582
> Cr-Commit-Position: refs/heads/master@{#396493}

TBR=haraken@chromium.org,jyasskin@chromium.org,yutak@chromium.org,esprehn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615174
Committed: https://crrev.com/c70d00665c49b700f2e4f5795044cce1812e6ef9
Cr-Commit-Position: refs/heads/master@{#396641}

[sof, 2016-05-28 11:38:06]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2016-05-28 11:38:06]

Created Revert of Expand WTF::StringView's API to be more like StringPiece.

[commit-bot: I haz the power, 2016-05-28 11:38:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2025503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2025503002/1

[commit-bot: I haz the power, 2016-05-28 11:38:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-28 11:38:39]

Failed to apply patch for
third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp:139
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp'
with conflicts.
  U third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp

Patch:       third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
Index: third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
diff --git a/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
b/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
index
a4f4b997fd5e27be932abc49ec012d045112143f..13ae63b0bd9b8cd44e4fbb9f7322ddd87980ede7
100644
--- a/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
+++ b/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
@@ -139,9 +139,7 @@
     ASSERT(contentID.isEmpty() || contentID[0] == '<');
 
     StringBuilder stringBuilder;
-    stringBuilder.append("--");
-    stringBuilder.append(boundary);
-    stringBuilder.append("\r\n");
+    stringBuilder.append("--" + boundary + "\r\n");
 
     stringBuilder.appendLiteral("Content-Type: ");
     stringBuilder.append(resource.mimeType);
@@ -167,7 +165,7 @@
 
     if (!resource.url.protocolIsAbout()) {
         stringBuilder.appendLiteral("Content-Location: ");
-        stringBuilder.append(resource.url.getString());
+        stringBuilder.append(resource.url);
         stringBuilder.appendLiteral("\r\n");
     }

[sof, 2016-05-28 11:51:52]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-05-28 11:52:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2025503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2025503002/1

[commit-bot: I haz the power, 2016-05-28 11:52:47]

Description was changed from

==========
Revert of Expand WTF::StringView's API to be more like StringPiece. (patchset
#12 id:220001 of https://codereview.chromium.org/2007103003/ )

Reason for revert:
Many a heap-buffer-overflow ASan failures,
 

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/b...

Original issue's description:
> Expand WTF::StringView's API to be more like StringPiece.
> 
> StringView no longer owns the string passed into it, and can now wrap
> a raw ptr to some characters.
> 
> This allows us to leverage the inline strlen optimization where the
> compiler will embed the length of literal strings into the binary. It
> also allows the deletion many overloaded methods that used to take
> an LChar*, UChar* or String and can now just take a StringView instead.
> 
> For example the two constructors in TextRun are now a single one that
> takes a StringView. This needed to be done in this patch to avoid
> ambiguous constructors.
> 
> Future patches will replace CSSParserString with StringView, and also
> vastly simplify the huge number of overloads on various methods. We'll
> also expand the API surface of StringView to include the many useful
> operations that StringPiece has.
> 
> BUG=615174
> 
> Committed: https://crrev.com/330deea56e27bc760fa52101040a51428bb7f582
> Cr-Commit-Position: refs/heads/master@{#396493}

TBR=haraken@chromium.org,jyasskin@chromium.org,yutak@chromium.org,esprehn@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615174
==========

to

==========
Revert of Expand WTF::StringView's API to be more like StringPiece. (patchset
#12 id:220001 of https://codereview.chromium.org/2007103003/ )

Reason for revert:
Many a heap-buffer-overflow ASan failures,
 

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/b...

Original issue's description:
> Expand WTF::StringView's API to be more like StringPiece.
> 
> StringView no longer owns the string passed into it, and can now wrap
> a raw ptr to some characters.
> 
> This allows us to leverage the inline strlen optimization where the
> compiler will embed the length of literal strings into the binary. It
> also allows the deletion many overloaded methods that used to take
> an LChar*, UChar* or String and can now just take a StringView instead.
> 
> For example the two constructors in TextRun are now a single one that
> takes a StringView. This needed to be done in this patch to avoid
> ambiguous constructors.
> 
> Future patches will replace CSSParserString with StringView, and also
> vastly simplify the huge number of overloads on various methods. We'll
> also expand the API surface of StringView to include the many useful
> operations that StringPiece has.
> 
> BUG=615174
> 
> Committed: https://crrev.com/330deea56e27bc760fa52101040a51428bb7f582
> Cr-Commit-Position: refs/heads/master@{#396493}

TBR=haraken@chromium.org,jyasskin@chromium.org,yutak@chromium.org,esprehn@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615174
==========

[commit-bot: I haz the power, 2016-05-28 11:52:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-28 11:54:07]

Description was changed from

==========
Revert of Expand WTF::StringView's API to be more like StringPiece. (patchset
#12 id:220001 of https://codereview.chromium.org/2007103003/ )

Reason for revert:
Many a heap-buffer-overflow ASan failures,
 

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/b...

Original issue's description:
> Expand WTF::StringView's API to be more like StringPiece.
> 
> StringView no longer owns the string passed into it, and can now wrap
> a raw ptr to some characters.
> 
> This allows us to leverage the inline strlen optimization where the
> compiler will embed the length of literal strings into the binary. It
> also allows the deletion many overloaded methods that used to take
> an LChar*, UChar* or String and can now just take a StringView instead.
> 
> For example the two constructors in TextRun are now a single one that
> takes a StringView. This needed to be done in this patch to avoid
> ambiguous constructors.
> 
> Future patches will replace CSSParserString with StringView, and also
> vastly simplify the huge number of overloads on various methods. We'll
> also expand the API surface of StringView to include the many useful
> operations that StringPiece has.
> 
> BUG=615174
> 
> Committed: https://crrev.com/330deea56e27bc760fa52101040a51428bb7f582
> Cr-Commit-Position: refs/heads/master@{#396493}

TBR=haraken@chromium.org,jyasskin@chromium.org,yutak@chromium.org,esprehn@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615174
==========

to

==========
Revert of Expand WTF::StringView's API to be more like StringPiece. (patchset
#12 id:220001 of https://codereview.chromium.org/2007103003/ )

Reason for revert:
Many a heap-buffer-overflow ASan failures,


https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/b...

Original issue's description:
> Expand WTF::StringView's API to be more like StringPiece.
>
> StringView no longer owns the string passed into it, and can now wrap
> a raw ptr to some characters.
>
> This allows us to leverage the inline strlen optimization where the
> compiler will embed the length of literal strings into the binary. It
> also allows the deletion many overloaded methods that used to take
> an LChar*, UChar* or String and can now just take a StringView instead.
>
> For example the two constructors in TextRun are now a single one that
> takes a StringView. This needed to be done in this patch to avoid
> ambiguous constructors.
>
> Future patches will replace CSSParserString with StringView, and also
> vastly simplify the huge number of overloads on various methods. We'll
> also expand the API surface of StringView to include the many useful
> operations that StringPiece has.
>
> BUG=615174
>
> Committed: https://crrev.com/330deea56e27bc760fa52101040a51428bb7f582
> Cr-Commit-Position: refs/heads/master@{#396493}

TBR=haraken@chromium.org,jyasskin@chromium.org,yutak@chromium.org,esprehn@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615174

Committed: https://crrev.com/c70d00665c49b700f2e4f5795044cce1812e6ef9
Cr-Commit-Position: refs/heads/master@{#396641}
==========

[commit-bot: I haz the power, 2016-05-28 11:54:08]

Patchset 1 (id:??) landed as
https://crrev.com/c70d00665c49b700f2e4f5795044cce1812e6ef9
Cr-Commit-Position: refs/heads/master@{#396641}

[haraken, 2016-05-28 16:01:56]

LGTM