components/data_reduction_proxy.gypi - Issue 2025443002: Refactoring data reduction proxy some methods to common

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy.gypi

Issue 2025443002: Refactoring data reduction proxy some methods to common (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/components_tests.gyp ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy.gypi

diff --git a/components/data_reduction_proxy.gypi b/components/data_reduction_proxy.gypi

index 17608f013aa938714d7dd0f9a43f5bf39033cad8..471659cf2283dd7ba50145c908e7ca51d222a78a 100644

--- a/components/data_reduction_proxy.gypi

+++ b/components/data_reduction_proxy.gypi

@@ -56,22 +56,20 @@

'data_reduction_proxy_core_browser_deps' : [

'data_reduction_proxy_version_header',

'../base/base.gyp:base',

'../crypto/crypto.gyp:crypto',

'pref_registry',

'data_reduction_proxy_core_common_sources' : [

# Note: sources list duplicated in GN build.

'data_reduction_proxy/core/common/data_reduction_proxy_bypass_action_list.h',

'data_reduction_proxy/core/common/data_reduction_proxy_bypass_type_list.h',

- 'data_reduction_proxy/core/common/data_reduction_proxy_client_config_parser.cc',

- 'data_reduction_proxy/core/common/data_reduction_proxy_client_config_parser.h',

'data_reduction_proxy/core/common/data_reduction_proxy_config_values.h',

'data_reduction_proxy/core/common/data_reduction_proxy_event_creator.cc',

'data_reduction_proxy/core/common/data_reduction_proxy_event_creator.h',

'data_reduction_proxy/core/common/data_reduction_proxy_event_storage_delegate.h',

'data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc',

'data_reduction_proxy/core/common/data_reduction_proxy_event_store.h',

'data_reduction_proxy/core/common/data_reduction_proxy_headers.cc',

'data_reduction_proxy/core/common/data_reduction_proxy_headers.h',

'data_reduction_proxy/core/common/data_reduction_proxy_params.cc',

'data_reduction_proxy/core/common/data_reduction_proxy_params.h',

@@ -185,22 +183,26 @@

'sources': [

'<@(data_reduction_proxy_core_browser_sources)',

'data_reduction_proxy/core/browser/data_store_impl.cc',

'data_reduction_proxy/core/browser/data_store_impl.h',

{

# GN version: //components/data_reduction_proxy/core/common

'target_name': 'data_reduction_proxy_core_common',

'type': 'static_library',

+ 'defines': [

+ 'USE_GOOGLE_API_KEYS'

+ ],

'dependencies': [

'../base/base.gyp:base',

+ '../google_apis/google_apis.gyp:google_apis',

'../url/url.gyp:url_lib',

'data_reduction_proxy_proto',

'include_dirs': [

'..',

'sources': [

'<@(data_reduction_proxy_core_common_sources)'